Giter VIP home page Giter VIP logo

Comments (4)

weotch avatar weotch commented on September 14, 2024

Can you send a screencap video of what you're experiencing?

Btw, the spirit of the focal point feature was to pass the selection through to CSS for use with background-size: cover. So it's kinda independent from your crop selection, which should output an image URL for a crop that has the same bounds as your choice in Decoy.

from decoy.

SomosAMambo avatar SomosAMambo commented on September 14, 2024

Clients could be creatures reigned by whatsoever logic, so, picture the following use case:

A client uploads a image for a marquee which has a 16/9 ratio and 1600x900 pixels on desktop. But the uploaded image has 3800x4200px. The client sets the focal point. In the template we have a ->crop(1600x900)->bkgd. The returned image is cropped to the center of the original, losing the focal point reference (which is percentual to original image scale).

That's why we suggested methods that maintain the original ratio but resizes the image for bandwidth saving, etc.

We noticed that we can force aspect ratio in the image field... this kinda solves the "issue"...

from decoy.

weotch avatar weotch commented on September 14, 2024

Yeahhhhh, I see what you mean.

It's almost like two different types of coordinates:

  1. An x,y to center the crop around when cropped to an aspect ratio that is different than the source aspect ratio
  2. An x,y to passthrough to CSS to inform the background-position when using cover (which is the current implementation).

You are right that the forcing the aspect ratio kinda solves this, however, currently you can't force the user to use the crop tool and set an aspect ratio.

A way I would like to sovle for your use case is, when an aspect ratio is defined for image, automatically create a cropping bounds at the aspect ratio and don't allow the user to clear it. So if you specify an aspect, it is always applied as a crop. And it defaults to the center for the image.

Does that make sense? Thoughts?

from decoy.

SomosAMambo avatar SomosAMambo commented on September 14, 2024

Totally.

I was experimenting with this idea. The only problem I've found is that when resizing/moving the crop boundaries, the focal point could be left outside of it.

from decoy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.