Prevent adding class if not specified a class about blade-icons HOT 8 CLOSED

I see. That could indeed be beneficial. I'll re-open this and leave it open for now. I don't think I'll get to this for the 0.4.0 release but maybe later on.

from blade-icons.

Yep, that would be cool to add.

from blade-icons.

I'm not sure what the problem is. Do you mean that at the moment when you call svg_image('Foo') twice that the second outputted SVG doesn't has the Foo class? Can you try this with the next version branch? #50

from blade-icons.

Going to close this one. Feel free to provide feedback when you can.

from blade-icons.

@driesvints
I mean if I have a svg file like this:

<svg class="foobar">...</svg>

svg_image('Foo') will erase the original class attribute and bring me this:

<svg>...</svg>

from blade-icons.

@yaquawa is right. I have the same issue. I have an already applied class on the svg, but when I want to add new classes when using the injector you’ve build, it erases the original class.

from blade-icons.

@extrabright if you have already applied class on the SVG, i think you need to set default classes in the config file (in case you have the same value of class for all SVG)
if not, the browser will always override this by passing an explicit class with your attributes.

from blade-icons.

I'm going to close this one as I don't think it's feasible to ever solve this in a clean way. It would mean the library would need to check every single icon for existing attributes. I think the direction I want to take the package more is to having icons not implement any attributes that aren't needed to "shape" the icon like class, id, etc. and let those be added through the package instead.

from blade-icons.