SVG with style tag + Vue about blade-icons HOT 9 CLOSED

This is a bit out of scope of this library I'm afraid as we can't control the elements that you place inside your svgs.

from blade-icons.

Hmmm ok.

But maybe it should be noted to the documentation that this library cannot handle SVG namespaces as it takes valid markup and renders it gibberish:

// SVG 
<svg:svg width="300px" height="200px">
    <svg:circle cx="150" cy="100" r="50" fill="#ff0000"/>
</svg:svg>

// Blade
{{ @svg('/path/to/file', 'myclass') }}

// Output
<svg class="myclass":svg width="300px" height="200px">
    <svg class="myclass":circle cx="150" cy="100" r="50" fill="#ff0000"/>
</svg:svg>

from blade-icons.

Why would <svg:svg be valid?

from blade-icons.

Well I didn't write the spec but I see it being allowed:
https://www.w3.org/TR/SVG2/struct.html#Namespace
https://developer.mozilla.org/en-US/docs/Web/SVG/Namespaces_Crash_Course

from blade-icons.

I see. Thanks for making me aware.

Does the parent always use <svg:svg or could it be something else as well like <svg:foo?

from blade-icons.

It's actually a prefix and it's reused for each element. I believe if it's different from svg, it needs to be defined with the xmlns attribute:

<foo:svg xmlns:foo="http://www.w3.org/2000/svg" width="300px" height="200px">
    <foo:circle cx="150" cy="100" r="50" fill="#ff0000"/>
</foo:svg>

from blade-icons.

Well, I wouldn't need this myself but would be open to prs that implement this in a nice and clean way. We're currently undergoing some transition however with #50 so you might wanna hold off until that's done.

from blade-icons.

No problem.

I understand that this will never be used 99.99% of the time. I just noticed it when trying to find a workaround with a problem on Vue's end.

from blade-icons.

I'm going to close this as I don't intend to implement this myself any time soon but happy to look at a PR if anyone wants to send one in 👍

from blade-icons.