ViewException with Blade components about blade-icons HOT 9 CLOSED

Hmm that should work just fine. Did you try clearing your views?

from blade-icons.

Views cleared, no changes.

from blade-icons.

It's weird because I'm using atm as such and it works for me. So I'm wondering what's different for you. You're sure you're using the latest commit from the next version branch?

from blade-icons.

I installed it 30 minutes ago, but to be sure:

composer.json

{
    ...
    "require": {
        ...
        "nothingworks/blade-svg": "dev-next-version"
    },
    ...
}

$ composer update
Updating dependencies (including require-dev)         
Nothing to install or update
...
Discovered Package: nothingworks/blade-svg

$ php artisan view:clear
Compiled views cleared!

I still got a ViewException.

from blade-icons.

Has it something to do with the fact that the Factory is defined as a singleton in the Service Provider but is actually never called (so the registerComponents() method can't do its magic) ?

from blade-icons.

I added this inside the registerFactory() of BladeInconsServiceProvider to instantiate the singleton, and it works now:

private function registerFactory(): void
{
    /* ... */

    $this->app->make(Factory::class);
}

from blade-icons.

Or just bind the instance:

private function registerFactory(): void
{
    $config = $this->app->make('config')->get('blade-icons');

    $factory = new Factory(new Filesystem(), $config['class']);

    foreach ($config['sets'] as $set => $options) {
        $options['path'] = $this->app->basePath($options['path']);

        $factory->add($set, $options);
    }

    $this->app->instance(Factory::class, $factory);
}

from blade-icons.

@fredericseiler thanks, that's a good tip. Just pushed a commit which should fix this. Not sure why I didn't caught this before.

from blade-icons.

Fixed indeed, thank you!

from blade-icons.