Improve `assertComponentRenders` from ComponentTestCase. about blade-ui-kit HOT 5 CLOSED

Sigh, I know. While I was developing Blade UI Kit I spent a lot of time searching for a HTML formatting library for PHP but there's nothing decent out there unfortunately. So I had to "homebrew" my own solution which is indeed not very feasible. I realise this is off putting in writing tests but I've maxed my limits atm at improving it. I'm hoping someone comes along that can help out here or that a decent HTML formatting library gets released at some point.

from blade-ui-kit.

Not sure exactly, but perhaps it would be easier/better for us to just strip white space out completely if possible?

I'd rather not tbh. That would clutter up the tests and make them very unreadable. I really want to dig into a better HTML formatter if possible.

from blade-ui-kit.

Yeah I've had issues in the past finding similar libraries. They are a nightmare... 😅

Not sure exactly, but perhaps it would be easier/better for us to just strip white space out completely if possible?
E.g this;

<div>
    <p></p>
</div>

Becomes this;

<div><p></p></div>

And we can assert against that.

I think this would also lead to the tests being more "reliable" since HTML itself doesn't really care about indentation/whitespace, so by removing it I think it would improve the tests by removing that variable from it entirely.😊

This also promotes the tests being more about the component output itself as opposed to worrying about whitespace which I think is a huge plus!

from blade-ui-kit.

@driesvints now that this PR (#154) is merged, I think you can close this issue.

from blade-ui-kit.

Thanks @alexmanase!

from blade-ui-kit.