Comments (7)
Was thinking about taking on a couple of these issues. For this one, do you want to turn Slack
itself into a struct, or put it somewhere else to avoid cluttering the macro-ful module, like Slack.Conn
?
from elixir-slack.
Also, how do you feel other structs, like Slack.Message
, Slack.User
. Slack.Channel
, etc?
from elixir-slack.
I would move the Slack
state first, but it would probably be in its own module. I was initially thinking Slack.State
but could be convinced of other names.
I think once that's done it'll make sense to re-evaluate the idea of Slack.Message
, user, etc.
from elixir-slack.
Both Slack.Struct
and Slack.State
seem a little nondescript, but I can't think of a great alternative. Slack.API
is kind of inaccurate. Slack.Conn
and Slack.Client
work better, but kind of already occupy a space in the domain model (websocket conn + client).
from elixir-slack.
Alternatively, flip it around such that the state is a %Slack{}
struct and library gets consumed with use Slack.API
(or Slack.Behaviour
, Slack.Client
)
from elixir-slack.
Slack.State
feels pretty weird because all the callbacks end up with a Slack.State
and a user-defined state
right next to each other in the params.
from elixir-slack.
I don't think it's too weird. 'Slack.Client' isn't bad either.
from elixir-slack.
Related Issues (20)
- Changelog HOT 1
- bots key not coming back in first api response HOT 1
- Chat.schedule_message HOT 4
- Hex has elixir-slack version with poison 3.0 HOT 2
- Upcoming slack change HOT 1
- Using content parameter of Slack.Web.Files.upload/3 HOT 1
- Bot crashes when user joins a channel HOT 13
- Support JSON payloads on web api chat methods HOT 12
- Token listed as required parameters when it should
- Unable to send messages unless removed then re-invited HOT 6
- Slack RTM breaking changes HOT 7
- [Feature Request] Support unfurl method HOT 2
- More beginner friendly documentation HOT 5
- Accessing `apps.events.authorizations.list` or advice on how to add support? HOT 1
- Channels functions deprecated by Slack
- [Question] Any chance to cut a new release on hex with the latest master? HOT 4
- Moving ownership to BEAM community HOT 9
- Current version is not published to hex.pm
- Slack API returned an error `method_deprecated. HOT 1
- Is this project still maintained? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elixir-slack.