Object not properly deserialized due to case-sensitivity about signalr HOT 11 CLOSED

@dave-bt To work around the problem before the fix is released you can force the Json serializer to always use lowercase property names like that:

    public class Post
    {
        [JsonPropertyName("author")]
        public string Author { get; set; } = "";

        [JsonPropertyName("content")]
        public string Content { get; set; } = "";
    }

You may need to add reference to the System.Text.Json package however if your class is located in netstandard2.1 project (default with Blazor .Shared projects):

  <ItemGroup>
    <PackageReference Include="System.Text.Json" Version="4.6.0-preview6.19303.8" />
  </ItemGroup>

from signalr.

I have the exact same issue. If I retrieve the object into my Blazor page using HttpClient it is populated, if I send the same object to my SignalR handler then the object's fields are all null. I may also be doing something very wrong - this is all rather new to me.

from signalr.

Ok, I found out that the problem is related to case-sensitivity of names of properties in my object.

The object that I was trying to send down SignalR looks like that:

    public class Post
    {
        public string Author { get; set; }
        public string Text { get; set; }
    }

Unfortunately, the System.Text.Json serializer on the server makes all property names lower-case before sending the object representation down the pipe. Client however, is more picky and expects exactly the same casing and thus, cannot match property names.

After changing my object to:

    public class Post
    {
        public string author { get; set; }
        public string text { get; set; }
    }

It started working.

from signalr.

I can see that I had .AddNewtonsoftJson() in my sample project after all, but it doesn't change anything because System.Text.Json and Newtonsoft Json both make serialized property names case-insensitive.

I can see that .Net client for SignalR core changed to also accept case-insensitive properties by default so it should be implemented as such in this client as well.

dotnet/aspnetcore#10774

from signalr.

This probably has to happen in HubConnection.cs where JsonSerializer.Parse<>() is called bunch of times.

That's where case-(in)sensivity matters.

Maybe it should be configurable when setting up the hub connection like with AddJsonProtocol of regular SignalR client. Or maybe this Blazor client has limited scope and we shouldn't be so flexible and enable only the default. I can prepare some PR for the latter one if that's the way the maintainers want to go with.

from signalr.

Hello @MiKom

Please open the PR if you are in the mood for that. It will be very much appreciated.

However, keep in mind that this package tries to only wrap the JS client as much as possible,

So if there is something that the C# is interfering we should indeed tackle.

Thanks!

from signalr.

I'll get to it tomorrow, it's getting late here :)

from signalr.

@MiKom Thank you very much indeed for that. Works a treat!

from signalr.

The preview7 package was published and it supports the JsonPropertyName. Please try it out.

from signalr.

The property names parsing is still not case-insensitive, also in preview7 right? Are there any plans to make it so?

from signalr.

Yes, the current System.Text.Json requires you to use JsonPropertyName.

from signalr.