Comments (2)
bellini666
commented on August 19, 2024
Hi @ammar-faifi ,
I don't see a problem in passing *args/**kwargs down to the resolver.
The whole permissioned directives think is basically a set of fancy middlewares =P. The AuthDirective basically retrieves the user and calls resolve_for_user, which subclasses must implement. When I implemented it I didn't pass *args/**kwargs because I didn't think that they would be useful. If I understood you issue correctly, by changing resolve_for_user and check_condition to receive those, you should be able to only have to implement your own directive and only have to worry about overriding check_condition, and everything will be there for you.
It should be a straightforward change. Do you want to try to open a PR for it? I'll gladly review it and make a new release once it is merged!
from strawberry-django-plus.
ammar-faifi
commented on August 19, 2024
yes I'd love. in fact, I did this change and it works just fine, I will open PR soon
from strawberry-django-plus.
Related Issues (20)
- enum validation HOT 4
- DeprecationWarning: Event driven styled extensions for on_request_start or on_request_end are deprecated HOT 1
- Optimization error: lookup was already seen with a different queryset. You may need to adjust the ordering of your lookups HOT 2
- ImportError: cannot import name 'Extension' from 'strawberry.extensions.base_extension' HOT 1
- Permissions: applying IsAuthenticated directive to entire schema HOT 3
- FieldDoesNotExist when using field via mixin HOT 5
- Per object permissions for mutation with an input type? HOT 3
- Getting `totalCount` for paginated results HOT 1
- Filter on a field leads to optimization error HOT 13
- Field extensions are ignored with gql.django.type
- Extending build in create mutations when only null=True HOT 5
- Relay connection does not work with async HOT 10
- Support standard property fields HOT 2
- custom ordering enum object has no attribute '_type_definition' HOT 8
- Optimization doesn't work with two nested fragments HOT 4
- Native Django async queries HOT 2
- Async get_queryset not supported when using query optimizer HOT 5
- Private fields not present in resolvers HOT 2
- Custom get_queryset of nested nodes not used HOT 5
- Setting user in test cases HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from strawberry-django-plus.