router_result_dump contains deps on negative values about rrrr HOT 3 CLOSED

Something like this?

diff --git a/router.c b/router.c
index 0f7909c..702be23 100644
--- a/router.c
+++ b/router.c
@@ -367,7 +367,7 @@ uint32_t router_result_dump(router_t *prouter, router_request_t *preq, char *buf
}
//b += sprintf (b, "round %d ", round);
uint32_t last_stop = states[s].back_stop;

•        if (s < 0 || s > router.tdata.n_stops) { 
  

•        if (last_stop == NONE || s == NONE || s > router.tdata.n_stops) { 
           // this was causing segfaults
           b += sprintf (b, "neg stopid %d\n", s);
           break;
  

from rrrr.

Actually it's redundant since NONE is the max integer. Just do > nstops, which will include and special values on a uint.

-a

Stefan de Konink [email protected] a écrit :

Something like this?

diff --git a/router.c b/router.c
index 0f7909c..702be23 100644
--- a/router.c
+++ b/router.c
@@ -367,7 +367,7 @@ uint32_t router_result_dump(router_t *prouter,
router_request_t *preq, char *buf
}
//b += sprintf (b, "round %d ", round);
uint32_t last_stop = states[s].back_stop;

•        if (s < 0 || s > router.tdata.n_stops) { 
  

•        if (last_stop == NONE || s == NONE || s >
  

  router.tdata.n_stops) {
  // this was causing segfaults
  b += sprintf (b, "neg stopid %d\n", s);
  break;

---

Reply to this email directly or view it on GitHub:
#17 (comment)

Andrew

Sent from a device without a keyboard. Please excuse my brevity and any absurd auto-correct errors.

from rrrr.

I am adding code to interpret epoch times as date&time, and apply the datemask.

Stefan de Konink [email protected] a écrit :

Something like this?

diff --git a/router.c b/router.c
index 0f7909c..702be23 100644
--- a/router.c
+++ b/router.c
@@ -367,7 +367,7 @@ uint32_t router_result_dump(router_t *prouter,
router_request_t *preq, char *buf
}
//b += sprintf (b, "round %d ", round);
uint32_t last_stop = states[s].back_stop;

•        if (s < 0 || s > router.tdata.n_stops) { 
  

•        if (last_stop == NONE || s == NONE || s >
  

  router.tdata.n_stops) {
  // this was causing segfaults
  b += sprintf (b, "neg stopid %d\n", s);
  break;

---

Reply to this email directly or view it on GitHub:
#17 (comment)

Andrew

Sent from a device without a keyboard. Please excuse my brevity and any absurd auto-correct errors.

from rrrr.