code should not use eval() about mage-enhanced-admin-grids HOT 1 CLOSED

Though I agree with you, in fact I did not get much feedbacks concerning this since the launch of the extension (actually, it must nearly be the second or third one).

Anyway, the reason why the code uses eval is that one of the main requirement for the extension, when I started developing it 2 years ago, was to keep it as much compatible as possible with the rest, while being completely transparent for the core and 3rd party extensions, and adding lots of features to the grids.
To achieve this, one of the solutions - if not the only - was to create, for each grid that it rewrites, a dynamic class inheriting from the corresponding class, and that should be used instead. This way, eg, all instanceof and related calls are ensured to be kept working.
At the time, the only way I found to do so was to use eval, knowing that yet today I'm not sure there are another solutions, and this, even if eval has its drawbacks - at least, security ones do not concern us -.
Reflection could be considered, as it brings almost everything that's needed, but yet it lacks the dynamic inheritance and class name, that I'm not sure that we could easily get rid of.

However, if you have some ideas on how it could be used, I'm completely opened concerning a possible refactoring of this part :)

from mage-enhanced-admin-grids.