Giter VIP home page Giter VIP logo

Comments (5)

mage-eag avatar mage-eag commented on July 19, 2024

As there is no delay when just using the core (as far as I know / have tested), it would depend on whether the extension you use is rather common or not, and if enabling the extension on the corresponding grids has an actual added value. Otherwise, it would be simpler to just turn off their rewrites (and in the case of a common extension, maybe add them by default to the exceptions list).

from mage-enhanced-admin-grids.

aligentjim avatar aligentjim commented on July 19, 2024

The extension in question is custom code that was written for the client. It adds three more grids to the product edit form, much like cross sells or upsells. The extension looks like a fairly standard admin grid implementation, nothing out of the ordinary. As the custom code provides significant business value for the customer, disabling it isn't an option. Adding those three grids to the exclusions list for CustomGrid makes the problem go away, but does not resolve the underlying issue.

I am happy to try and extract the minimal amount of custom code from this client's site to reproduce the issue if that helps.

from mage-enhanced-admin-grids.

mage-eag avatar mage-eag commented on July 19, 2024

When I was talking about turning off the rewrites, I meant to disable the corresponding custom grids (in System > Custom Grids > List), sorry for the misunderstanding :)

And concerning a minimal piece of code allowing to reproduce the issue, if you can extract it then yes it would be really welcome, as that may finally furthermore allow to find a potentially more general problem. Thanks !

from mage-enhanced-admin-grids.

paales avatar paales commented on July 19, 2024

I've noticed performance problems with grids in combination with the adminhtml/widget_grid_serialize block, if on-ajax not only the grid is reloaded but the serialize block is loaded again it causes performance problems in javascript.

Example XML

    <adminhtml_inventoryupdates_product>
        <block type="core/text_list" name="root" output="toHtml">
            <block type="ho_inventoryupdates/adminhtml_inventoryupdates_edit_tab_product" name="ho_inventoryupdates_edit_tab_product" />
            <block type="adminhtml/widget_grid_serializer" name="product_grid_seralizer">
                <reference name="product_grid_seralizer">
                    <action method="initSerializerBlock">
                        <grid_block_name>ho_inventoryupdates_edit_tab_product</grid_block_name>
                        <data_callback>getSelectedProducts</data_callback>
                        <hidden_input_name>links[qtys]</hidden_input_name>
                        <reload_param_name>products</reload_param_name>
                    </action>
                </reference>
            </block>
        </block>
    </adminhtml_inventoryupdates_product>

    <adminhtml_inventoryupdates_productgridonly>
        <block type="core/text_list" name="root">
            <block type="ho_inventoryupdates/adminhtml_inventoryupdates_edit_tab_product" name="ho_inventoryupdates_edit_tab_product" />
        </block>
    </adminhtml_inventoryupdates_productgridonly>

Not sure if it is related, but though I'd share my experience. :)

from mage-enhanced-admin-grids.

aligentjim avatar aligentjim commented on July 19, 2024

@paales great observation. That's exactly what's happening in our situation! Thanks for your assistance! 👍

from mage-enhanced-admin-grids.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.