Complete Update Dropdown Work about blockchain-wallet-v4-frontend HOT 6 CLOSED

My mistake. I see that when there are multiple BTC accounts, the template header does not render correctly and I did not account for the to dropdown.

from blockchain-wallet-v4-frontend.

There are a few issues at least from what I can see blocking #837 from being merged.

1. Send BTC/BCH/ETH output dropdown logic. The interaction no longer works as intended.

2. Exchange no longer works when there is more than one btc/bch account

3. Some small styling changes. Background should be white, cursor pointer, no border-radius (?)

from blockchain-wallet-v4-frontend.

Thank you for the feedback.

Could you clarify further on the send BTC/BCH/ETH interaction? I am running yarn start on the development branch and the interaction seems to be in line with recent changes to the fixDropdowns branch.

Also, how should I run locally? I am unable to re-create the error on the exchange route

Thank you

from blockchain-wallet-v4-frontend.

@mchlcrtz check out the difference between dev and fixDropdowns:

dev: https://gyazo.com/875cc5c3e4ed09d5fbff6e1fd63abbf7
fixDropdowns: https://gyazo.com/5e6a31981954226730581fe18278d395

In regards to exchange, what happens if you add another BTC account (in settings) then go to exchange and pick a state.

from blockchain-wallet-v4-frontend.

Hi @plondon, apologies on the delay. I had my hands full last week. I see that the changes merged to development have updated headers in exchange. Might there be any additional work that needs to be done? Perhaps the icons?

from blockchain-wallet-v4-frontend.

Hey @mchlcrtz thanks I'll close this issue then. I actually opened an issue with react-select so we can customize the dropdown. See: JedWatson/react-select#2947

from blockchain-wallet-v4-frontend.