Comments (9)
Hi, I could look into this when I can!
from blockchain-wallet-v4-frontend.
Awesome, thanks so much @sendmebiscuits!
Just comment on the issue with the areas that you're working on so we don't have overlapping work between people. Also, if you have any questions or need help testing, feel free to reach out to me or @plondon anytime!
from blockchain-wallet-v4-frontend.
Sure thing! I'll take care of those in a bit.
from blockchain-wallet-v4-frontend.
Quick question before I start touching anything, should code in the deprecated lifecycle methods be refactored based on how the React Docs suggest? Or just a complete deletion of the deprecated method?
from blockchain-wallet-v4-frontend.
Let's just start with removing the deprecated methods please
from blockchain-wallet-v4-frontend.
Hey guys, I finally had some time to go through the code. I found and deleted 1 componentWillMount and 1 componentWillReceiveProps in packages/blockchain-info-components/src/Carousels/Carousel/index.js and packages/blockchain-info-components/src/Form/SelectInput/index.js. I'll push the changes and make a pull request.
from blockchain-wallet-v4-frontend.
Thanks @sendmebiscuits, we appreciate your help π
There's a bunch more in packages/blockchain-wallet-v4-frontend/src
. Let me know if you want to tackle those as well.
from blockchain-wallet-v4-frontend.
Work ongoing here: #876
from blockchain-wallet-v4-frontend.
Closing!
from blockchain-wallet-v4-frontend.
Related Issues (20)
- I AM UNABLE TO TRANSFER BTC FROM MY TRADING ACCOUNT TO ANOTHER BITCOIN WALLET HOT 4
- Blockchain seperti taikπ€£π€£βοΈ
- Tg
- ![Logo](https://cdn.ast.checkmarx.net/integrations/logo/Checkmarx.png)
- King
- Help my please
- R313839
- ![Logo](https://cdn.ast.checkmarx.net/integrations/logo/Checkmarx.png) HOT 1
- BUG REPORT HOT 1
- Mine
- Login
- Not signing in
- home
- 2
- 1488800
- 1488800 HOT 1
- Assets HOT 3
- Mister
- Critical: Impossible to login to the wallet HOT 1
- API Question HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blockchain-wallet-v4-frontend.