Update code to support ITKv5 multi-threading model about itkstreamingsinc HOT 10 CLOSED

That just about did it! Thanks!
I just had to tweak the capture.

from itkstreamingsinc.

Just stumbled op on this. It is not clear to me what functionality is missing in ITK-5 since the integration of itkStreamingSinc with InsightSoftwareConsortium/ITK#855.

from itkstreamingsinc.

Good point, in that case adding a clarification to the README should be sufficient. Is it something you could help with ?

from itkstreamingsinc.

Two things missing from ITKv5.

• The BoundingBox Filter, but that is trivial replaces by using a binary threshold filter and then the streaming label statistics image filter now in ITK.

• The MPI streaming filter is not in ITKv5. It's not been used for a bit. This filter likely should be updated and moved into it's own proper ITK remote module. This filter offers a very unique way to do things in ITK which may be of interest to people as the basis for future work.

from itkstreamingsinc.

This module is quite integrated into the ITK pipeline. It should be worth updating the module.

from itkstreamingsinc.

The ImageSinc base class filter uses the deprecated threading components to multi-thread on the input region of an image filter. It's not clear how to use the new components to do a similar thing.
@dzenanz

from itkstreamingsinc.

StreamedGenerateData and ThreaderCallback could be replaced by this definition:

template <class TInputImage>
void
ImageSinc<TInputImage>
::StreamedGenerateData( unsigned int itkNotUsed(inputRequestedRegionNumber) )
{
  this->GetMultiThreader()->SetNumberOfThreads( this->GetNumberOfThreads() );
  const ThreadIdType  total = this->GetRegionSplitter()->GetNumberOfSplits( m_CurrentInputRegion,  this->GetNumberOfThreads() );
  this->GetMultiThreader()->ParallelizeArray(
    0,
    total,
    [&m_CurrentInputRegion](SizeValueType threadId)
    {
        InputImageRegionType splitRegion = m_CurrentInputRegion;
        this->GetRegionSplitter()->GetSplit( threadId, total, splitRegion );
        this->ThreadedStreamedGenerateData(splitRegion, threadId);
    },
    nullptr); // \Modules\Core\Common\include\itkProgressTransformer.h would need to be used to properly report progress here
}

I have not tried to compile this.

from itkstreamingsinc.

Just noticed that this issue was started before InsightSoftwareConsortium/ITK#855 started.
@jcfr @blowekamp issue ready to be closed?

from itkstreamingsinc.

Indeed, it can be closed. Thanks for pointing this out.

@blowekamp Could you update the readme and archive the project ?

from itkstreamingsinc.

archive the project

As long as ITK-4 is still widely in use, I think the project should not (yet) be archived.

from itkstreamingsinc.