What would be the changes need if this module used in node v6.11 ? about node-oom-heapdump HOT 3 CLOSED

Hi @sahanmal,

Apart from the fact that Node.js 6 is going out of maintenance mode april next year, the changes needed for node-oom-heapdump would probably be quite minor.

I haven't specifically tested it, but changes are to be expected in:

• https://github.com/blueconic/node-oom-heapdump/blob/master/lib/node_oom_heapdump_native.cc#L59

When looking at v8-profiler (which supports multiple versions), it looks like the code this module currently uses should work for Node.js 6.11 as well (see https://github.com/node-inspector/v8-profiler/blob/master/src/heap_profiler.cc#L75).

Have you tested in Node.js 6.11? What didn't work or what is the error you got?

from node-oom-heapdump.

Ah, now i see.
'SetOOMErrorHandler' is not available in Node.js 6. You could try to substitute that with "SetFatalErrorHandler", like is done here.

make: Entering directory `/node_modules/node-oom-heapdump/build'
  CXX(target) Release/obj.target/node_oom_heapdump_native/lib/node_oom_heapdump_native.o
../lib/node_oom_heapdump_native.cc: In function 'void ParseArgumentsAndSetErrorHandler(const v8::FunctionCallbackInfo<v8::Value>&)':
../lib/node_oom_heapdump_native.cc:71:12: error: 'class v8::Isolate' has no member named 'SetOOMErrorHandler'
   isolate->SetOOMErrorHandler(OnOOMError);
            ^

Does that help?

from node-oom-heapdump.

Closing issue as there is no response.

from node-oom-heapdump.