Comments (4)
@RyanDevlin Please find the diff for the fix below. Basically when there's only one entry in lfu item's map, increment removes that entry from it and create a new lfu item for that entry. That's why list keeps growing on every increment. Looking in the diff would give you a better explanation.
diff --git a/lfu.go b/lfu.go
index f781a1f..d42d5d2 100644
--- a/lfu.go
+++ b/lfu.go
@@ -181,17 +181,22 @@ func (c *LFUCache) increment(item *lfuItem) {
currentFreqElement := item.freqElement
currentFreqEntry := currentFreqElement.Value.(*freqEntry)
nextFreq := currentFreqEntry.freq + 1
- delete(currentFreqEntry.items, item)
-
- nextFreqElement := currentFreqElement.Next()
- if nextFreqElement == nil {
- nextFreqElement = c.freqList.InsertAfter(&freqEntry{
- freq: nextFreq,
- items: make(map[*lfuItem]struct{}),
- }, currentFreqElement)
+ if len(currentFreqEntry.items) == 1 {
+ currentFreqEntry.freq = nextFreq
+ } else {
+ delete(currentFreqEntry.items, item)
+
+ nextFreqElement := currentFreqElement.Next()
+ if nextFreqElement == nil {
+ nextFreqElement = c.freqList.InsertAfter(&freqEntry{
+ freq: nextFreq,
+ items: make(map[*lfuItem]struct{}),
+ }, currentFreqElement)
+ }
+ nextFreqElement.Value.(*freqEntry).items[item] = struct{}{}
+
+ item.freqElement = nextFreqElement
}
- nextFreqElement.Value.(*freqEntry).items[item] = struct{}{}
- item.freqElement = nextFreqElement
}
// evict removes the least frequence item from the cache.
from gcache.
Thanks @RyanDevlin @shubhati.
Definitely, keeping an empty freqEntry
is very inefficient in memory usage.
This problem occurs not only when it calls increment
, but also when we delete an element of freqEntry
that has only one element in remove
.
@shubhati, thanks for your patch and contribution! But it seems to not work if nextFreqElement.freq
does not match nextFreq
. I'll open a pull-request that includes tests and a patch that fixes remove
later.
from gcache.
I have identified the fix for this issue. Would love to contribute
from gcache.
Out of curiosity, what was the fix you identified?
from gcache.
Related Issues (20)
- ARC cache does not work as expected (when used with expiry) HOT 6
- example have some wrong HOT 1
- Support context? HOT 1
- any idea to support window based lfu ?
- Size unit HOT 2
- Please, evict expired objects preferentially
- increment method in lfu.go cause memory leak HOT 1
- Batch operations are very common. Do you consider supporting batch read and batch load interfaces?
- Do you support go mod? HOT 1
- how to share between multiple processes? HOT 2
- Use github action instead of wercker
- 问下啊,初始化的size参数单位是缓存个数还是容量啊 HOT 4
- Can getValue use RLock? HOT 2
- panic happens in v0.0.2 HOT 4
- Is it necessary to dispose the cache instance when it's useless?
- Allow to change cache size
- i think it need a optimize HOT 1
- I make a generic version
- Project Status
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gcache.