Giter VIP home page Giter VIP logo

Comments (4)

shubhati avatar shubhati commented on May 28, 2024 1

@RyanDevlin Please find the diff for the fix below. Basically when there's only one entry in lfu item's map, increment removes that entry from it and create a new lfu item for that entry. That's why list keeps growing on every increment. Looking in the diff would give you a better explanation.

diff --git a/lfu.go b/lfu.go
index f781a1f..d42d5d2 100644
--- a/lfu.go
+++ b/lfu.go
@@ -181,17 +181,22 @@ func (c *LFUCache) increment(item *lfuItem) {
        currentFreqElement := item.freqElement
        currentFreqEntry := currentFreqElement.Value.(*freqEntry)
        nextFreq := currentFreqEntry.freq + 1
-       delete(currentFreqEntry.items, item)
-
-       nextFreqElement := currentFreqElement.Next()
-       if nextFreqElement == nil {
-               nextFreqElement = c.freqList.InsertAfter(&freqEntry{
-                       freq:  nextFreq,
-                       items: make(map[*lfuItem]struct{}),
-               }, currentFreqElement)
+       if len(currentFreqEntry.items) == 1 {
+               currentFreqEntry.freq = nextFreq
+       } else {
+               delete(currentFreqEntry.items, item)
+
+               nextFreqElement := currentFreqElement.Next()
+               if nextFreqElement == nil {
+                       nextFreqElement = c.freqList.InsertAfter(&freqEntry{
+                               freq:  nextFreq,
+                               items: make(map[*lfuItem]struct{}),
+                       }, currentFreqElement)
+               }
+               nextFreqElement.Value.(*freqEntry).items[item] = struct{}{}
+
+               item.freqElement = nextFreqElement
        }
-       nextFreqElement.Value.(*freqEntry).items[item] = struct{}{}
-       item.freqElement = nextFreqElement
 }
 
 // evict removes the least frequence item from the cache.

from gcache.

bluele avatar bluele commented on May 28, 2024 1

Thanks @RyanDevlin @shubhati.

Definitely, keeping an empty freqEntry is very inefficient in memory usage.

This problem occurs not only when it calls increment, but also when we delete an element of freqEntry that has only one element in remove.

@shubhati, thanks for your patch and contribution! But it seems to not work if nextFreqElement.freq does not match nextFreq. I'll open a pull-request that includes tests and a patch that fixes remove later.

from gcache.

shubhati avatar shubhati commented on May 28, 2024

I have identified the fix for this issue. Would love to contribute

from gcache.

RyanDevlin avatar RyanDevlin commented on May 28, 2024

Out of curiosity, what was the fix you identified?

from gcache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.