pymavlink set_mode ack, wrong constant being used about ardusub-gitbook HOT 3 CLOSED

But this constant: MAVLINK_MSG_ID_SET_MODE seemingly should be MAV_CMD_DO_SET_MODE ?

Yes, I believe that's correct. SET_MODE used to be a message but is now a command, and that example hasn't been updated to reflect that. There's a more up to date example here as part of a more complete program, although it requires Python >= 3.8.

from ardusub-gitbook.

I see, thanks for the explanation! In your example you used two constants

            # check if acknowledged MAV_CMD_DO_SET_MODE or SET_MODE (old)
            if ack_msg.command in (176, 11):

I just pushed a PR, should I update it to also put the two constants there?

from ardusub-gitbook.

I just pushed a PR, should I update it to also put the two constants there?

I included both at the time for compatibility, and because I wasn’t sure whether the message was used by any of the send options. Looking again the acknowledgement is using the command protocol, which presumably wasn’t used when it was just a ‘message’, so receiving the message ID there is likely impossible anyway.

from ardusub-gitbook.