Comments (3)
Great work @joaoferreiro. I agree with your conclusion.
After assigning this to you, I noticed that cold boot had seemed to improve, and I believe it was possibly due to some dropped dependencies (reanimated and a gestures library) but I didn't look more deeply. I figured I'd keep you on this task so we could have access to the code and confirm the results.
Go ahead and upload the branch as code-split
and then leave it there. We'll retain it as a reference in case future cold boot times worsen.
from social-app.
react-native-bundler-splitter
- Encapsulated all of the main screens within the
register
method- With the exception of Login screen and MobileShell, Menu and TabSelector components
- Results:
- No visible improvement between the older version and the newest, using
react-native-blunder-splitter
- No visible improvement between the older version and the newest, using
Videos:
iPhone7WithoutSplitterDebug.MP4
iPhone7WithoutSplitterRelease.MP4
iPhone7WithSplitterDebug.MP4
iPhone7WithSplitterRelease.MP4
@pfrazee will research a bit more on how can we improve this stat tomorrow. Then I would suggest we connect to discuss next steps on this
from social-app.
@pfrazee just added react-native-bundle-splitter
's to all the components on the src/view
folder (despite only src/view/screens
) and the results are no different: no improvement on cold start time.
iPhone7WithoutSplitterRelease_2.MP4
iPhone7WithSplitterDebug_2.MP4
iPhone7WithSplitterRelease_2.MP4
Besides this, using this library would require us to change a lot of the folder structure that we currently have. Example:
Before:
After:
To conclude, unless we've received any comments on this I don't believe this is a major issue.
The cold-start time of the release version on an iPhone 7 is < 2sec. I've tested other social networks on an iPhone 8 and it's 3 to 5 sec. This makes me believe that we could drop this. Lmk what you think about it
from social-app.
Related Issues (20)
- Automatically Set Content Language Based On User Location HOT 2
- Title: Input Field Border Outline Obscures Text When Selecting Cached Email During Signup and SignIn HOT 1
- All inputs in SignUp and SignIn have scroll when selected and for a much padding HOT 3
- Provide ability to specify search order in the Web client URL HOT 2
- 1px of left Sidebar border visible when collapsed
- Kawaii logo shows wrong
- Add ability to middle click on a post replying to another post to open it in a new tab
- Labeler Limit : Moderation vs Message HOT 2
- White circle appears on some pages on back action HOT 1
- Dead click (but not really!) when clicking OP profile while composing reply
- RTL auto-detection makes PostMeta messy HOT 1
- bluesky chat bug - says deleted account on sender name when profile is deactivated HOT 1
- Kawaii Logo Truncated HOT 2
- Smaller text, icon, and user avatar on Android
- Add a native setting to hide from the feed posts containing images without alt text
- Tapping Unfollow on the Followers you know page doesn't change the button HOT 2
- Continue Thread Button Doesn't Work HOT 5
- User setting to toggle "like" visibility on posts HOT 1
- "Forking" labellers
- Custom subdomain handle suddenly stopped validating HOT 31
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from social-app.