Giter VIP home page Giter VIP logo

Comments (3)

pfrazee avatar pfrazee commented on August 16, 2024 1

Great work @joaoferreiro. I agree with your conclusion.

After assigning this to you, I noticed that cold boot had seemed to improve, and I believe it was possibly due to some dropped dependencies (reanimated and a gestures library) but I didn't look more deeply. I figured I'd keep you on this task so we could have access to the code and confirm the results.

Go ahead and upload the branch as code-split and then leave it there. We'll retain it as a reference in case future cold boot times worsen.

from social-app.

joaoferreiro avatar joaoferreiro commented on August 16, 2024

react-native-bundler-splitter

  • Encapsulated all of the main screens within the registermethod
    • With the exception of Login screen and MobileShell, Menu and TabSelector components
  • Results:
    • No visible improvement between the older version and the newest, using react-native-blunder-splitter

Videos:

iPhone7WithoutSplitterDebug.MP4
iPhone7WithoutSplitterRelease.MP4
iPhone7WithSplitterDebug.MP4
iPhone7WithSplitterRelease.MP4

@pfrazee will research a bit more on how can we improve this stat tomorrow. Then I would suggest we connect to discuss next steps on this

from social-app.

joaoferreiro avatar joaoferreiro commented on August 16, 2024

@pfrazee just added react-native-bundle-splitter's to all the components on the src/view folder (despite only src/view/screens) and the results are no different: no improvement on cold start time.

Videos:
https://user-images.githubusercontent.com/19496375/207385976-96b09c77-af85-4230-901e-a2e4f607a7a1.MP4

iPhone7WithoutSplitterRelease_2.MP4
iPhone7WithSplitterDebug_2.MP4
iPhone7WithSplitterRelease_2.MP4

Besides this, using this library would require us to change a lot of the folder structure that we currently have. Example:
Before:
Screenshot 2022-12-13 at 16 11 53
After:
Screenshot 2022-12-13 at 16 13 11

To conclude, unless we've received any comments on this I don't believe this is a major issue.
The cold-start time of the release version on an iPhone 7 is < 2sec. I've tested other social networks on an iPhone 8 and it's 3 to 5 sec. This makes me believe that we could drop this. Lmk what you think about it

from social-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.