Giter VIP home page Giter VIP logo

Comments (7)

bluz71 avatar bluz71 commented on August 15, 2024 1

Implementation done.
Please update.
Hopefully nvim-navic will look now look much nicer in your setup.
Let me know if there are any issues.

Best regards.

from vim-nightfly-colors.

bluz71 avatar bluz71 commented on August 15, 2024 1

Actually, I found your dotfiles, and I see where you create your own custom winbar with specific layout and highlight groups.

After looking at your winbar, there is nothing I need to do from my end.

Best regards.

from vim-nightfly-colors.

bluz71 avatar bluz71 commented on August 15, 2024

from vim-nightfly-colors.

LucasMartinsVieira avatar LucasMartinsVieira commented on August 15, 2024

Thanks for adding it. This improved my Neovim setup a lot! But i have an issue, i think the background color of the gps of nvim-navic should be the regular bg color of the colorscheme (in moonfly as well), it feels a little bit weird the way it is now. I think would be better.

I will make a Pr on both of your colorschemes repos and you decide if it's better or not.

best regards.

230226-2229-50
230226-2230-42

from vim-nightfly-colors.

bluz71 avatar bluz71 commented on August 15, 2024

navic could just as easily be used in the statusline as the winbar. I need to handle both cases.

The current committed code looks like this:

Current

Your proposed PR looks like this:

PR

Pay attention to the statusline; notice the black hole where navic is emitted (next to master branch).

Compare to the current committed code which blends everything together.

At the moment I can't accept the PR; not unless the statusline is taken into account.

from vim-nightfly-colors.

LucasMartinsVieira avatar LucasMartinsVieira commented on August 15, 2024

Okay i understand. Since i do not use navic in the statusline i wiil stick with my fork.

thanks for your attention and your time

best regards.

from vim-nightfly-colors.

bluz71 avatar bluz71 commented on August 15, 2024

Before you go, can you tell me what your winbar configuration is; I want to have a look at why your winbar looks like this:

winbar

The mix of dark background and lighter background bewilders me since I explicitly set the winbar color to something similar to the statusline background color (not exactly the same but similar).

Your winbar in the above screenshot is something I want to explore.

Cheers.

from vim-nightfly-colors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.