Comments (11)
bmuschko
commented on July 18, 2024
Please send a pull request if you are interested in a fix. Thanks!
from gradle-tomcat-plugin.
patric-r
commented on July 18, 2024
There are multiple issues of the same kind when using Gradle 7.0, e.g. tomcatJasper task is affected as well:
* What went wrong:
A problem was found with the configuration of task ':tomcatJasper' (type 'TomcatJasper').
- Type 'TomcatJasper' property 'jasperAttributes' is private and annotated with @Internal.
Reason: Annotations on private getters are ignored.
Possible solutions:
1. Make the getter public.
2. Annotate the public version of the getter.
Please refer to https://docs.gradle.org/7.0/userguide/validation_problems.html#private_getter_must_not_be_annotated for more details about this problem.
from gradle-tomcat-plugin.
patric-r
commented on July 18, 2024
I tried to get this fixed, however, the unit tests fail after cloning the repo (without any local changes),
unfortunately without any additional info/stacktrace (even with providing --stacktrace)
What I'm doing wrong, @bmuschko ?
[...]
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Runs Jasper compiler for Tomcat 6.0.x with default conventions FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at TomcatJasperFunctionalTest.groovy:36
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Runs Jasper compiler for Tomcat 7.0.x with default conventions FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at TomcatJasperFunctionalTest.groovy:36
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Runs Jasper compiler for Tomcat 8.0.x with default conventions FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at TomcatJasperFunctionalTest.groovy:36
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Runs Jasper compiler for Tomcat 8.5.x with default conventions FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at TomcatJasperFunctionalTest.groovy:36
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Runs Jasper compiler for Tomcat 9.0.x with default conventions FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at TomcatJasperFunctionalTest.groovy:36
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Can use Jasper compiler validation for Tomcat version 6.0.29 with attribute validateXml FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at TomcatJasperFunctionalTest.groovy:64
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Can use Jasper compiler validation for Tomcat version 6.0.39 with attribute validateTld FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at TomcatJasperFunctionalTest.groovy:64
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Can use Jasper compiler validation for Tomcat version 7.0.42 with attribute validateXml FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at TomcatJasperFunctionalTest.groovy:64
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Can use Jasper compiler validation for Tomcat version 7.0.50 with attribute validateTld FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at TomcatJasperFunctionalTest.groovy:64
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Can use Jasper compiler validation for Tomcat version 8.0.3 with attribute validateTld FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at TomcatJasperFunctionalTest.groovy:64
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Can use Jasper compiler validation for Tomcat version 9.0.1 with attribute validateXml FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at TomcatJasperFunctionalTest.groovy:64
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Throws exception using Jasper compiler validation for Tomcat version 6.0.39 with invalid attribute validateXml FAILED
org.spockframework.runtime.ConditionNotSatisfiedError at TomcatJasperFunctionalTest.groovy:94
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Throws exception using Jasper compiler validation for Tomcat version 7.0.42 with invalid attribute validateTld FAILED
org.spockframework.runtime.ConditionNotSatisfiedError at TomcatJasperFunctionalTest.groovy:94
com.bmuschko.gradle.tomcat.TomcatJasperFunctionalTest > Throws exception using Jasper compiler validation for Tomcat version 8.0.3 with invalid attribute validateXml FAILED
org.spockframework.runtime.ConditionNotSatisfiedError at TomcatJasperFunctionalTest.groovy:94
[...]
from gradle-tomcat-plugin.
patric-r
commented on July 18, 2024
@bmuschko any help is still appreciated.
Currently, gradle-tomcat-plugin is not working with gradle 7.x at all
It would be very nice to get this finally fixed.
from gradle-tomcat-plugin.
jshiell
commented on July 18, 2024
For the record, we moved to embedding Tomcat in the app, which nicely avoids this problem.
from gradle-tomcat-plugin.
patric-r
commented on July 18, 2024
@jshiell Thanks for the info. However, we're using this plugin solely for validating our web application (especially jsp compilation) during ci/release builds
from gradle-tomcat-plugin.
bmuschko
commented on July 18, 2024
@patric-r Those tests pass for me on my local machine as well as on CI. Are you executing the build with the checked-in Gradle Wrapper? Have a look at the test report for that source set to see the stack trace. I can't possibly know what's wrong with your test execution without seeing the stack trace.
from gradle-tomcat-plugin.
patric-r
commented on July 18, 2024
@bmuschko I did further investigating in the past hours. The reason is that the functional tests seems to try to download dependencies from the maven repository and testkits GradleRunner does not read the gradle.properties (due to test isolation) which means that my proxy settings are not available and therefore a silent timeout happens.
Are you aware of a workaround?
I know that you're busy and searching another maintainer for this project but would you mind fixing this issue?
Most probably, you only have to change a few getters to public. Thanks!
from gradle-tomcat-plugin.
bmuschko
commented on July 18, 2024
For reference: 20e46f1
from gradle-tomcat-plugin.
patric-r
commented on July 18, 2024
@bmuschko Thank you so much! I'll have a look.
One last thing: Any chance for a release containing those fixes?
from gradle-tomcat-plugin.
bmuschko
commented on July 18, 2024
@patric-r Yes, I will do so soon. Releasing requires more work on the build as JCenter doesn't exist anymore. Need to switch over all that publishing code to the Gradle plugin portal. Will take me a bit.
from gradle-tomcat-plugin.
Related Issues (20)
- Daemon does not stop HOT 4
- Define which war to use HOT 9
- Gradle Daemon - Caused by: java.lang.Error: factory already defined HOT 2
- Can I tell `TomcatRun` where is the exploded web directory? HOT 1
- Documentation - add example to compile translated jsps HOT 1
- Setting default jsp package name from org.apache.jsp to your choice HOT 2
- Acessing environment variables with the plugin HOT 1
- Gradle 6.2.2 shows deprecation warning regarding jasperAttributes HOT 3
- IllegalArgumentException: The AJP Connector is configured with secretRequired="true" but the secret attribute is either null or "". HOT 7
- How to run the Tomcat server at http://localhost:8080 instead of http://localhost:8080/ProjectName? HOT 2
- Skip Jar Scanning for Annotations HOT 1
- 2.6 Release HOT 3
- How to configure environment variables when calling tomcatRun? HOT 1
- Tomcat 10 support
- HTTP2 support
- does this can do like maven tomcat plugin which can build jar not war HOT 1
- Remove usage of WarPluginConvention
- Getting groovy.lang.MissingMethodException after upgrading to tomcat plugin 2.7.0, was using 2.5 before HOT 1
- The AJP Connector is configured with secretRequired="true"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gradle-tomcat-plugin.