Add command to edit an account about pick HOT 10 CLOSED

I'd like to flush out the usage for this one before implementing it; here's my first thought:

pick edit <name> <username|password>

Examples

# Edit a username

pick edit github username
Enter a new username for github
>

# Edit a password (generate a new one)

pick edit github password
Generate a new password for github (Y/n)?
>

# Edit a password (manual)

pick edit github password
Generate a new password for github (Y/n)?
> n
Enter a password for github
>

Thoughts?

from pick.

I think if we want to rename an account, e.g. github -> github/bndw, we should consider adding a mv command.

I'd prefer to stick to using built-in command names whenever possible. This keeps usage intuitive and familiar.

EDIT:
I wonder if we could achieve all of this with a mv command?

# Rename a credential/account

pick mv github github/bndw

# Change a username

pick mv github username [new username}

# Change a password

pick mv github password
...

from pick.

pick mv github password This is not intuitive.

# Rename an account

$ pick mv github github-new

# Change an account's username / password

$ pick edit github
Do you want to change the username (y/N)?
..
Do you want to change the password (y/N)?

$ pick edit github [user/name/username]
Enter a new username..

$ pick edit github [pswd/pass/password]
Generate a new password for github (Y/n)?

from pick.

pick mv github password This is not intuitive.

Agreed, scratch that one.

mv command
I'm happy with adding a mv command for renaming accounts.

edit command
An interactive edit command sounds good, however I am not a fan of the variable argument naming, [user/name/username] and [pswd/pass/password].

I see no benefit in having the user make a cognitive decision about which variety to use. I'd much prefer to offer a single way to do a task.

$ pick edit github
Do you want to change the username (y/N)?
..

$ pick edit github username
Enter a new username..

$ pick edit github password
Generate a new password for github (Y/n)?

EDIT:
I'm conflicted, especially on the pick edit github username bit. I'd like to think/explore this one before rushing an implementation.

from pick.

We need to have an password-history, so your old passwords are not lost

I'm not sure I see the value of this; could you explain the use case?

from pick.

Imagine this scenario:

1. Add new account with a custom / pick-generated password
2. You now want to change the password with $ pick edit github password (or similar)
3. Let pick generate you the new password and copy it to your clipboard
4. Now I would go to Github and change the password there, but I somehow need to access the old password

IMO it's too risky not to store a complete history of an account's passwords (or at least the last two or so).

from pick.

Thanks, that makes sense. I wonder if we should consider the same for any other fields on safe.Account, for example username.

from pick.

Personally, I don't need a history for an account's username. A history of the passwords is sufficient.

from pick.

SGTM. I think adding a []string to safe.Account to hold previous passwords may be sufficient.

from pick.

This is now almost in develop and will be available in the next release. Thanks @leonklingele!

from pick.