actions-rs/cargo@v1 use Node12. Please update the following actions to use Node.js 16 about cargo-machete HOT 8 CLOSED

Hi! Not sure, is it a problem that CI's using an old version of Node? This action was just a cache for the binary I suppose, happy to use anything else that'd be as simple and well maintained.

from cargo-machete.

For example if I add this to a git workflow:

jobs:
  audit:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v3
      - name: Machete
        uses: bnjbvr/cargo-machete@main

I will get this warning
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

from cargo-machete.

Alrighty then, using the one you linked in the first comment sounds good to me 👍 Would you be willing to provide a PR?

from cargo-machete.

Alrighty then, using the one you linked in the first comment sounds good to me 👍 Would you be willing to provide a PR?

If you can review #99 . Also if you have a way to test it and make sure it works let me know. I was not sure how to test this.

from cargo-machete.

Code lgtm. To test it, you should be able to replace in your own config file something like:

 - uses: bnjbvr/cargo-machete@main

to

 - uses: istellino-chub/cargo-machete@fix-node12-warning

and run that in a PR so as to trigger the build. Once you've done that, can you paste a link of the CI run here please? Thanks in advance.

from cargo-machete.

Code lgtm. To test it, you should be able to replace in your own config file something like:

 - uses: bnjbvr/cargo-machete@main

to

 - uses: istellino-chub/cargo-machete@fix-node12-warning

and run that in a PR so as to trigger the build. Once you've done that, can you paste a link of the CI run here please? Thanks in advance.

@bnjbvr I tested following your instructions replacing it on our workflow file and works fine. I cannot paste the CI run because is a private repo

from cargo-machete.

https://github.com/bnjbvr/rustatouille/actions/runs/7412912153/job/20170714796 is a successful run.

from cargo-machete.

Fixed by #99

from cargo-machete.