Giter VIP home page Giter VIP logo

Comments (3)

bobbingwide avatar bobbingwide commented on July 29, 2024

This solution is in v0.4.1 and works with SB v0.2.1... but the value for Seen before is incorrect!
I need to check which template is being used.
example https://s.b/bigram/bigram/shark-bloke/ and https://s.b/bigram/shark%20bloke/

from bigram.

bobbingwide avatar bobbingwide commented on July 29, 2024

When the URL is shark bloke the content that's being displayed is the media, post type attachment.
This suggests that the request has not been handled

image

  • The post content, on the right, includes the image.
  • There is no featured image on the left.
  • Note: The image's styling needs some care and attention. If bleeds over the sidebar.

from bigram.

bobbingwide avatar bobbingwide commented on July 29, 2024

Analysis of the request and the query being performed indicated that the code was being prevented from working by the same logic that we looked at with duplicate permalinks. See https://github.com/bobbingwide/dupes/issues

When the bigram has a featured image then this is found by get_page_by_path().
For shark%20bloke the request becomes:

[page] => (string) ""
[pagename] => (string) "shark%20bloke"

But for a request which doesn't have a featured image eg six%20bells we see.

 [page] => (string) ""
 [name] => (string) "six%20bells"

Fortunately, we're able to overrwrite these requests.
But we should only do this when the pagename / name contains a blank ( %20 ) otherwise we may override a request to a valid page. eg submit-bigram

from bigram.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.