Improve [bw_plug] when oik-plugins post type defined locally about oik-bob-bing-wide HOT 5 CLOSED

The changes in 40a7b42 are ok for a simple link to a plugin but not for a table of plugins where we want to see data from WordPress.org. Until the code is implemented using a better class structure a pragmatic solution would be to used the cache method to load data for WordPress or WordPress and oik plugins when the table display is required.

from oik-bob-bing-wide.

Note: We still get the warning message.

from oik-bob-bing-wide.

Well, since this issue isn't yet closed I may as well add this new message.
It occurs when the locally cached plugin_info is from oik-plugins and doesnt contain a value for downloaded. The following function would appear to need to be improved.

function oikp_get_downloaded( $post, $version ) { 
  return( "" );
} 

or the routine that calls it.

/home/herb/public_html/wp-content/plugins/oik-bwtrace/includes/bwtrace-actions.php(279:2) bw_trace_error_handler(1) 120 3 2020-01-30T15:26:15+00:00 0.227250 0.000205 cf=genesis_loop,genesis_entry_content,the_content 11453 73 20664 29360128/29360128 768M F=887 err W3TC\Generic_Plugin::ob_callback,ob_gzhandler,autoptimizeMain::end_buffering
Array

[0] => (integer) 2
[1] => (string) "Warning: number_format() expects parameter 1 to be float, string given"
[2] => (string) "/home/herb/public_html/wp-includes/functions.php"
[3] => (integer) 397

@#:0 337 508

from oik-bob-bing-wide.

Workaround was to delete the transient data cached for the plugin from oik-plugins.com and reset the entry for the plugin.

from oik-bob-bing-wide.

Problem happened again on oik-plugins.com and oik-plugins.co.uk
Time to apply the fix!

from oik-bob-bing-wide.