Giter VIP home page Giter VIP logo

Comments (8)

bobbingwide avatar bobbingwide commented on June 24, 2024

Some of the SVG icons used for blocks no longer match the original dash icon.
If we want to use [bw_dash] to display these the code will need to be updated.
And because the SVG is more complex the logic to display the icons will need improving to cater for more than just the <path d= parameter.
First example is the archive icon.

from oik-bob-bing-wide.

bobbingwide avatar bobbingwide commented on June 24, 2024

Couple of things.

  • The SVG for the core blocks are not the same as the original dashicons.
  • The default size for the core block icons is 24. I originally used 20 but increased it for the core/archive icon.

Proposal

  • Extend the logic to support icons for core blocks as a separate type.
  • Treat core/archive as if it were font=core. ( or class=core ? )
  • Add a new font type of core and include all the icons in the core blocks.

from oik-bob-bing-wide.

bobbingwide avatar bobbingwide commented on June 24, 2024

Having created a separate block to display Block icons, I can now undo the changes to the SVG version of the archive icon. We'll keep the size at 24 pixels.

from oik-bob-bing-wide.

bobbingwide avatar bobbingwide commented on June 24, 2024

There are probably some new dashicons that we should be able to display

from oik-bob-bing-wide.

bobbingwide avatar bobbingwide commented on June 24, 2024

There are probably some new dashicons that we should be able to display

Yes there are. These were not included in v1.34.0 I’ll leave the issue open.

from oik-bob-bing-wide.

bobbingwide avatar bobbingwide commented on June 24, 2024

There are probably some new dashicons that we should be able to display

Having reworked the [bw_dash] shortcode to use the new list of SVG's available in WordPress's dash icons, icons and social links there are now over 600 SVG icons that can potentially be displayed. This is in addition to the Block icons!

The logic does not yet support the display of these SVG icons.
See also #46

from oik-bob-bing-wide.

bobbingwide avatar bobbingwide commented on June 24, 2024

I need to complete the documentation update for the 70 or so new icons in the dashicons set.
And mention the 280 or so WordPress icons.
Note: This excludes the Social links icons which aren't yet supported by the Icon control.

from oik-bob-bing-wide.

bobbingwide avatar bobbingwide commented on June 24, 2024

Closing this now that the Dashicon block supports over 580 SVG icons; some dashicons, others WordPress/Gutenberg icons.
Delivered in v2.2.1

from oik-bob-bing-wide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.