Giter VIP home page Giter VIP logo

Comments (3)

bogeychan avatar bogeychan commented on May 23, 2024 1

I got it working without using Bun.build. I adjusted the following parts of isFnUse, in case you encounter the same problem in the future with bun.

// >> INSERT
fnLiteral = fnLiteral.trimStart();
const argument = fnLiteral.startsWith('(')
? // (context) => {}
fnLiteral.slice(fnLiteral.indexOf('(') + 1, fnLiteral.indexOf(')'))
: // context => {}
fnLiteral.slice(0, fnLiteral.indexOf('=') - 1);
// << INSERT

// >> INSERT
if (argument.includes(`{${keyword}`) || argument.includes(`,${keyword}`))
return true;
// << INSERT
if (argument.includes(`{ ${keyword}`) || argument.includes(`, ${keyword}`))
return true;

I'll look into CommonJS support tomorrow

from elysia-polyfills.

bogeychan avatar bogeychan commented on May 23, 2024

Sounds good, I will give it a try.

But I think since you introduced code analysis, it won't work without a build step (before each run) because of bun transpile step, for example:

isFnUse

// Bun
let is = isFnUse(
  'set',
  `(context) => {
    if (handleOrigin(context.set, context.request), handleMethod(context.set), exposedHeaders.length)
      context.set.headers["Access-Control-Allow-Headers"] = typeof allowedHeaders === "string" ? allowedHeaders : allowedHeaders.join(", ");
    if (maxAge)
      context.set.headers["Access-Control-Max-Age"] = maxAge.toString();
    return new Response("", {
      status: 204
    });
  }`
);

console.log(is); // true

// Node
is = isFnUse(
  'set',
  `context => {
        handleOrigin(context.set, context.request);
        handleMethod(context.set);
        if (exposedHeaders.length) context.set.headers['Access-Control-Allow-Headers'] = typeof allowedHeaders === 'string' ? allowedHeaders : allowedHeaders.join(', ');
        if (maxAge) context.set.headers['Access-Control-Max-Age'] = maxAge.toString();
        return new Response('', {
          status: 204
        });
      }`
);

console.log(is); // false

bugs in Bun.build / bun build kinda blocks progress atm

from elysia-polyfills.

bogeychan avatar bogeychan commented on May 23, 2024

CommonJS support should be added without build-step in @bogeychan/[email protected] and [email protected]:

yarn create elysia my-elysia-app --template node

If you want to support ESM hybrid with CJS in Elysia you can follow this blog post. I implemented the same approach.

Furthermore you have to use "moduleResolution": "nodenext", (i.e. specify all imports and exports with .js extension)

from elysia-polyfills.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.