Software versions See your docs build Browser n

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

[BUG] JS errors on Bokeh docs page about bokeh HOT 7 OPEN

cdeil commented on May 22, 2024

[BUG] JS errors on Bokeh docs page

from bokeh.

Comments (7)

choldgraf commented on May 22, 2024 1

I'd recommend opening an issue in the pydata-sphinx-theme repository in case it's a problem over there. It looks like the HTML structure has changed and the JS selector didn't change to accommodate it, but I haven't been following the development too closely so don't know where the problem may be

from bokeh.

bryevdv commented on May 22, 2024

This is some issue with the Sphinx theme, not Bokeh itself.

@choldgraf any thoughts on what could be going amiss (or who is the best person to ask these days)?

cc @tcmetzger

from bokeh.

bryevdv commented on May 22, 2024

@mosc9575 before we make an issue over there, do you have any bandwidth for a quick look? Does this reproduce locally, and if so does a simple change like updating the theme version fix things?

from bokeh.

mosc9575 commented on May 22, 2024

Only the search button on the start page is broken. The button works on other pages like first steps and gallery and I don't understand why. I also think that the posted JS error is unrelated, because it also appears on pages with working search button.

The error in the browser console comes from the version banner and I don't know how to fix it. See

bokeh/docs/bokeh/source/_static/custom.js

Lines 10 to 26 in e380566

 // Display a version warning banner if necessary 

 $(document).ready(function () { 

 const randid = Math.random().toString(36).substring(2, 15) + Math.random().toString(36).substring(2, 15); 

 $.getJSON('/switcher.json?v=' + randid , function (data) { 

 // old versions have a unified latest/x.y.z, things are split starting with 3.0 

 if (BOKEH_CURRENT_VERSION != data[1].version) { 

 let msg 

 if (data.findIndex((elt) => elt.version == BOKEH_CURRENT_VERSION) < 0 ) { 

 msg = "DEVELOPMENT / PRE-RELEASE" 

 } else { 

 msg = "PREVIOUS RELEASE" 

 } 

 const content = $('<div class="version-alert">This page is documentation for a ' + msg + ' version. For the latest release, go to <a href="https://docs.bokeh.org/en/latest/">https://docs.bokeh.org/en/latest/</a></div>') 

 $('#banner').append(content); 

 } 

 }) 

 })

I also build the docs on my local machine with pydata-sphinx-theme 0.15.2 and 0.15.3dev0 and I can't see if it works, because the search button is broken for local pages. There is an older issue 1654 which could be related.

from bokeh.

choldgraf commented on May 22, 2024

Just noting that I believe version warning banners are now built into the theme, so you could try using that and see if that removes the error

https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/announcements.html#version-warning-banners

from bokeh.

Recommend Projects

[BUG] JS errors on Bokeh docs page about bokeh HOT 7 OPEN

Comments (7)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// Display a version warning banner if necessary
	$(document).ready(function () {
	const randid = Math.random().toString(36).substring(2, 15) + Math.random().toString(36).substring(2, 15);
	$.getJSON('/switcher.json?v=' + randid , function (data) {
	// old versions have a unified latest/x.y.z, things are split starting with 3.0
	if (BOKEH_CURRENT_VERSION != data[1].version) {
	let msg
	if (data.findIndex((elt) => elt.version == BOKEH_CURRENT_VERSION) < 0 ) {
	msg = "DEVELOPMENT / PRE-RELEASE"
	} else {
	msg = "PREVIOUS RELEASE"
	}
	const content = $('<div class="version-alert">This page is documentation for a ' + msg + ' version. For the latest release, go to <a href="https://docs.bokeh.org/en/latest/">https://docs.bokeh.org/en/latest/</a></div>')
	$('#banner').append(content);
	}
	})
	})