Holidays not working when config.time_zone is changed in application.rb about business_time HOT 9 OPEN

OK, i dug through the code deeper and found the issue. My holidays seem to be storing in BusinessTime::Config.holidays as TimeWithZones on initialize instead of Dates. I am using the default initializer with the code:

BusinessTime::Config.load("#{Rails.root}/config/business_time.yml")

and business_time.yml file is shown in my first post.

When i update my /initializers/business_time.rb file to:

BusinessTime::Config.load("#{Rails.root}/config/business_time.yml")
BusinessTime::Config.holidays = BusinessTime::Config.holidays.map(&:to_date)

the holidays are stored as Dates and everything works as planned.

from business_time.

Anyone? Are holidays working for everyone else? I don't really see how I'm doing anything wrong with configuring the holidays for it to be an issue on my end, but if it is, i'd be glad to know what I'm doing wrong.

from business_time.

Adnan:
In Rails console, run the following, does it return false?

date = Date.parse(2013, 05, 27)
Time.workday?(date)

from business_time.

@marshallshen : This is the output from my rails console:

1.9.3p327 :003 > date = Date.parse('2013/05/27')
=> Mon, 27 May 2013
1.9.3p327 :004 > Time.workday?(date)
=> true
1.9.3p327 :005 > BusinessTime::Config.holidays
=> [Mon, 18 Feb 2013 00:00:00 PST -08:00, Mon, 27 May 2013 00:00:00 PDT -07:00, Thu, 04 Jul 2013 00:00:00 PDT -07:00, Mon, 02 Sep 2013 00:00:00 PDT -07:00, Thu, 28 Nov 2013 00:00:00 PST -08:00, Fri, 29 Nov 2013 00:00:00 PST -08:00, Wed, 25 Dec 2013 00:00:00 PST -08:00, Tue, 31 Dec 2013 00:00:00 PST -08:00, Wed, 01 Jan 2014 00:00:00 PST -08:00]

from business_time.

Ok, so i figured out what the issue is. business_time holidays seems to fail when the rails time zone is not set to UTC. I currently have this line in my application.rb:

config.time_zone = 'Pacific Time (US & Canada)'

When i comment this out, the holidays work. However, i need to keep that as my time zone.

This gem says that's its timezone agnostic so I'm going to assume this is a bug.

from business_time.

I agree, sounds like a bug. Can you write a test to expose it or better yet, include a fix in a pullup request?

from business_time.

@AdnanTheExcellent's solution solved the problem here.
I'm using a different default time_zone as well.

from business_time.

Ok, I'm prepping for a new release this weekend, and this is top of my list. We put a lot of work into dealing with timezones... It is said that every software engineer eventually learns to hate timezones, and this proves that point

from business_time.

Awesome. Glad this is going to get patched up in a more elegant solution than what i did.

from business_time.