<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="26

cc <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

I would break it into three steps: <div class="highlight highlight-source-js notra

Following are the validation for bin <div class="h

Fix bolt install validations about bolt HOT 6 OPEN

boltpkg commented on May 18, 2024

Fix bolt install validations

from bolt.

Comments (6)

jamiebuilds commented on May 18, 2024

cc @lukebatchelor

from bolt.

lukebatchelor commented on May 18, 2024

Hmmm... I did notice it was moved, do you think itd be better to have the checked up location, or separated into another module?

from bolt.

jamiebuilds commented on May 18, 2024

I would break it into three steps:

async function install() {
  let everythingNeededToSymlink = await validateAndReturnInstallSymlinksStuff();
  await yarn.install();
  await symlinkAllTheStuff(everythingNeededToSymlink);
}

from bolt.

ajaymathur commented on May 18, 2024

Half way through, I realised we cannot move logic to get symlinks/ and validate for bin before install as it we don't know bin (s) until they are installed..

Should we just have validation logic for external and internal dependencies before install but validation for bin after install?

from bolt.

jamiebuilds commented on May 18, 2024

What are we validating with bins?

from bolt.

ajaymathur commented on May 18, 2024

Following are the validation for bin

pathIsInside(actualBinFile, project.pkg.nodeModules)`

if (!actualBinFileRelative) {
      throw new BoltError('${binName} is not a symlink');
}

There is a comment on this too:

 // TODO: For now, we'll search through each of the bin files in the Project and find which ones are
 // dependencies we are symlinking. In the future, we should really be going through each dependency
 // and all of its dependencies and checking which ones expose bins so that all the transitive ones
 // are included too

from bolt.

Recommend Projects