JetBrains kotlin problems about bolts-android HOT 9 CLOSED

Unfortunately, I'm not too familiar with kotlin. Are you sure that TaskCompletionSource being an internal class is the problem?

Are you able to initialize TaskCompletionSource on it's own like the following?

Task<String>.TaskCompletionSource tcs = Task.create();
tcs.setResult("ggg");

(This is in Java as I'm unfamiliar with Kotlin syntax)

Additionally, TaskCompletionSource needs to modify the internals of Task, so it'd require a huge amount of refactoring to make it a non-internal class.

from bolts-android.

I made TaskCompletionSource static and its works fine now.

Check out here: https://github.com/romansl/Bolts-Android/blob/989541b7492452189da34a3277284778fbba6616/Bolts/src/bolts/Task.java#L502

from bolts-android.

Would be a breaking change

from bolts-android.

Could this be a bug in Kotlin that has been fixed since?

from bolts-android.

This is actually not a bug with Kotlin, it is by design. You can read here http://blog.jetbrains.com/kotlin/2015/04/upcoming-changes-and-more/.

When a generic class Outer has an inner class Inner, Java allows us to use generic parameters of Outer inside Inner:

Although very logical, this feature also has rather few use cases, and current implementation we have in Kotlin requires a lot of work before it is production quality. So, we are going to forbid this, and maybe implement it in later releases of Kotlin.

from bolts-android.

A good workaround I have found is to write an extension in Kotlin for TaskCompletionSource like so:

fun Task.TaskCompletionSource.setResult(result: Any) {
    Util.setResult(this, result)
}

where Util is a Java class with static method that takes the TaskCompletionSource and the result:

public static void setResult(Task.TaskCompletionSource tcs, Object result) 
    tcs.setResult(result);
}

from bolts-android.

Can someone check if #84 fixes the Kotlin problems?

from bolts-android.

I can confirm #84 fixes the problem with Kotlin.

from bolts-android.

Awesome, thanks!

from bolts-android.