Blank view for BFAppLinkReturnToRefererView about bolts-objc HOT 3 OPEN

Thanks for the feedback! You are correct that the README is misleading, since correct layout of the view currently requires explicitly setting its width to be the full width of its superview. We had discussion about whether -showViewForRefererAppLink: should explicitly set the width prior to displaying the view, but came down on the side of thinking it was better for the developer to explicitly own this layout (though, as you noticed, the README unfortunately neglects to mention it). From your feedback, it sounds like you feel it would be preferable for the controller to take responsibility for resizing the view to the proper width; is that accurate?

Your other suggestions are also interesting, although somewhat more involved. I'm not sure it's a good idea to require providing a view controller in the non-navigation-controller case, because we don't strictly need one. On the other hand, it would provide a consistent model to retrieve the correct superview, without requiring the developer to explicitly add the view and size it in the non-navigation-controller case. We'll look into whether that does actually simplify usage of the view.

from bolts-objc.

From your feedback, it sounds like you feel it would be preferable for the controller to take responsibility for resizing the view to the proper width; is that accurate?

Yes. I think you guys should strive to make this as automagical as possible and deal with edge cases as they appear — if they even make sense — as opposed to giving too much control to (which is also a synonym for "more work required from") the developer.

As for the second suggestion, your interpretation is spot on.

from bolts-objc.

I started working on this "automagical solution" for the BFAppLinkReturnToRefererController:
master...stuffle:change/default-behavior

It currently works for displaying the back button in a UINavigationController.

Default usage is simple:

# MyViewController.m or MyNavigationController.m

- (void)showRefererBackButtonIfNeeded
{
    BFURL *receivedAppLinkURL = ((STUAppDelegate *)[[UIApplication sharedApplication] delegate]).receivedAppLinkURL;
    if (receivedAppLinkURL != nil) {
        if (self.appLinkReturnToRefererController == nil) {
            self.appLinkReturnToRefererController = [[BFAppLinkReturnToRefererController alloc] initWithViewController:self];
        }
        [self.appLinkReturnToRefererController showViewForRefererAppLink:receivedAppLinkURL.appLinkReferer];
    } else {
        [self.appLinkReturnToRefererController removeFromViewController];
    }
}

Since I use it in a UINavigationController that is nested in a UITabBarController, I found it necessary to redraw/reposition the back button in the following events:

# MyNavigationController.m

- (void)viewWillAppear:(BOOL)animated
{
    [super viewWillAppear:animated];
    [self showRefererBackButtonIfNeeded];
    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(applicationDidBecomeActiveNotification:) name:UIApplicationDidBecomeActiveNotification object:nil];
}

- (void)viewDidAppear:(BOOL)animated
{
    [super viewDidAppear:animated];
    [self showRefererBackButtonIfNeeded];
}

- (void)applicationDidBecomeActiveNotification:(NSNotification *)notification
{
    [self showRefererBackButtonIfNeeded];
}

- (void)viewDidDisappear:(BOOL)animated
{
    [super viewDidDisappear:animated];
    [[NSNotificationCenter defaultCenter] removeObserver:self name:UIApplicationDidBecomeActiveNotification object:nil];
}

- (void)setNavigationBarHidden:(BOOL)hidden animated:(BOOL)animated
{
    [super setNavigationBarHidden:hidden animated:animated];
    [self showRefererBackButtonIfNeeded];
}

from bolts-objc.