Giter VIP home page Giter VIP logo

Comments (2)

bklimt avatar bklimt commented on July 3, 2024

Objective-C uses errors and exceptions differently, whereas Java just has the one concept of exceptions, so it's not really possible for them to be identical. isFaulted would have to mean something like "has an error or has an exception", but then you'd still need to check which kind to do anything reasonable. If you have a more specific use case that doesn't work right with the existing semantics, please share it with us.

from bolts-objc.

marchy avatar marchy commented on July 3, 2024

Actually the whole point is that for most errors the presentation layer in the app (presumably the one invoking BFTask and handling the error callbacks) does not need to do anything different based on the kind of error. It simply needs to put the UI in an error state or clear out the UI async indicators. Special circumstances that require custom errors can be handled as you mention above, by checking whether it's an error or an exception. This is however the 5-10% case not the 90%.

In terms of presenting the actual error, common errors should be handled at a lower level anyways (ie: networking layer) and not performed by each caller. This is especially so on iOS where dialogs can be presented from any thread and don't need to be invoked using a live Activity Context as is the case on Android.

It would be easier for callers to check "if( task.isFaulted ) {..}" instead of checking "if( task.error != nil || task.exception != nil ) {..}" in every single place. Not only is it just bad API to require consumers to check whether two different properties are nil instead of having a semantic representation that achieves exactly what they want; but it is also error-prone and easily forgettable. A good API should guide you to what's needed and prevent you from screwing up.

I am confident this is a mis-design on your guys' part. Please reconsider and re-open the request.
The added benefit is it will also be more consistent with the Android library. :)

from bolts-objc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.