Completed set before the task has actually completed about bolts-objc HOT 5 CLOSED

I'm not sure I understand, [BFTask waitUntilFinished] waits until the current task is completed, and if it completed successfully you will be immediately able to access the result.

Continuations may run after waitUntilFinished has returned, but those are for following tasks and not the current task so I see no issue there.

from bolts-objc.

In this specific case, I expected the execution block to be called before [BFTask waitUntilFinished] returned which isn't the case. I expect this as I need to use the results of that block immediately after the call to [BFTask waitUntilFinished] on the same thread.

Continuations do continue for other tasks within the queue, thats fine and as expected, but this refers to the specific task being waited on.

from bolts-objc.

If you do something like:

BFTask *task = [client findAsync:query];
[task continueWithSuccessBlock:^id(BFTask *task) {
  NSLog(@"Continuation has run");
  return nil;
}]
[task waitUntilCompletion];

then when waitUntilCompletion returns the continuation will not have executed yet (and the message will not have been logged).

What you need is to do use the task returned from continueWithBlock:

BFTask *task = [client findAsync:query];
BFTask *continuationTask = [task continueWithSuccessBlock:^id(BFTask *task) {
  NSLog(@"Continuation has run");
  return nil;
}]
[continuationTask waitUntilCompletion];

then waitUntilCompletion will not return until the continuation has run (and message logged).

from bolts-objc.

Ok, thats useful to know. The behaviour of my initial structure still seems incorrect though, but maybe that's just a documentation issues.

I say that because I have the same code paths for both async and (for testing) synchronous calls with an optional call to [task waitUntilCompletion], which to me made the most sense.

But like I say, maybe it just needs to be documented.

from bolts-objc.

Thanks guys!
Closing this one, as the issue seems to be resolved now.
Feel free to reopen or send a Pull Request if you think there is anything actionable here.

from bolts-objc.