Giter VIP home page Giter VIP logo

Comments (4)

josephearl avatar josephearl commented on July 23, 2024

@nlutsenko-fb @grantland

The problem is that the continuation block for -[BFTask taskForCompletionOfAllTasks:] gives cancellations precedent over errors.

Is this the desired behaviour for taskForCompletionOfAllTasks / whenAll?

from bolts-objc.

grantland avatar grantland commented on July 23, 2024

This seems like a bug in the iOS implementation. The .NET docs state that it goes Error > Cancelled > Success (https://msdn.microsoft.com/en-us/library/hh194766(v=vs.110).aspx) and our Android implementation follows this as well:

Task<Void> taskA = Task.forError(new RuntimeException("This task failed."));
Task<Void> taskB = Task.forResult(null);
Task<Void> taskC = Task.cancelled();
Task.whenAll(Arrays.asList(taskA, taskB, taskC)).continueWithTask(new Continuation<Void, Task<Void>>() {
  @Override
  public Task<Void> then(Task<Void> task) throws Exception {
    Log.d("test", "isFaulted=" + task.isFaulted() + " isCancelled=" + task.isCancelled() + " isComplete=" + task.isCompleted());
    return null;
  }
}).waitForCompletion();
04-15 13:50:08.109    1955-1970/? D/test﹕ isFaulted=true isCancelled=false isComplete=true

from bolts-objc.

 avatar commented on July 23, 2024

Fixed by #93

from bolts-objc.

jhollida24 avatar jhollida24 commented on July 23, 2024

Thanks guys!

from bolts-objc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.