Comments (5)
Looks good! Thank you so much for the report and the PR! Merged and I'll try to include it in an existing PR to update golangci-lint
!
from wsl.
Another thing to note: I'm using golangci-lint to run wsl, and so I could add // nolint: wsl
to ignore these failures. However, that comment then gets put into the godoc:
from wsl.
Thank you for this report! I'll look into this asap!
from wsl.
@bombsimon I hacked up a fix which I'll PR soon, though it's a bit messy 😉
from wsl.
See #39 for a potential fix
from wsl.
Related Issues (20)
- Treat short declarations as declarations, not assignments (enhancement) HOT 11
- AllowSeparatedLeadingComment doesn't allow one comment + WS before first statement HOT 2
- False-negative cuddled assignment line above HOT 3
- Require new lines after multiline function signature HOT 1
- Drop overlapping support for v4 HOT 4
- allow go statements invoke inline function HOT 4
- Read closing bracket(s) as empty lines HOT 4
- [Docs] `force-err-cuddling` is referenced as `enforce-err-cuddling` in the documentation HOT 2
- Comment in default block should not be seen as trailing comment HOT 1
- Incorrect check of assignment usage in loop and if statements HOT 1
- `++`/`--` should be treated as an assignment HOT 1
- Group `DeclStmt` instead of splitting with empty lines
- Error installing: does not contain packages matching github.com/bombsimon/wsl/v4/cmd/... HOT 5
- `else`/`else if` blocks are not processed
- Install instructions don't work (for me) HOT 1
- `--fix` ? HOT 2
- Issue with accessing functions and variables across files within the same package in v4 HOT 2
- Allow cuddled return for variable just declared HOT 1
- Cuddle function call expression on var declared in line above HOT 2
- output of wsl and golangci-lint are different HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wsl.