Windows Visual Studio 2022 C++17/C++20 failed compilation of src.hpp. about redis HOT 14 OPEN

FWIW There are a lot more things in C++20 and boost that fail in MSVC permissive mode. Permissive mode is deeply broken, but that is why there is strict mode and it is the default when using C++20. I was just starting with C++20 in MSVC so I didn't know. The errors make no sense to me but I have yet to find failures in strict mode.

from redis.

I am also testing with vs 2022 in the CI and it is passing, see

Can you provide me with the example you are trying to compile? Regarding BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT, there was a user having a problem with it, see #110

I have also made some changes in the place you are pointing to after the release, they are still on the develop. You can try using it as I described in #175 (comment)

from redis.

Marcelo, the code I was trying to compile was pretty simple:

//#define BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT
#include "boost/redis/src.hpp"

I hadn't gotten any further (or I ifdef'ed the rest when this part failed).

Possibly relevant command line options are:

/ifcOutput ".\VS17.0\x64Release" /GS /W4 /Gy /Zc:wchar_t /I"....\esc\boost" /I"....\esc\openssl\include" /Z7 /Gm- /O2 /Ob1 /Fd".\VS17.0\x64Release" /Zc:inline /fp:precise /D "NDEBUG" /D "_CONSOLE" /D "WINNT" /D "_VC80_UPGRADE=0x0600" /D "_MBCS" /errorReport:prompt /GF /WX- /Zc:forScope /Gd /MT /std:c++20 /Fa".\VS17.0\x64Release" /EHsc /nologo /Fo".\VS17.0\x64Release" /diagnostics:column

I am generally using static libraries, as I have been successfully doing for quite some time, but this failure is compilation.

I am pulling down a freshest copy of boost includes to see if that makes a difference. I failed to fully follow your instructions on the pull. Retrying.

from redis.

I have merged two PR in the develop branch after Boost. 1.84 was out, one of them changed the connection constructor. Make sure you checkout the develop branch git submodule foreach --recursive git checkout develop as I linked you above.

Otherwise, please provide me with the exact details of the vs version you are using and I will check if it is not already being tested in CI and whether github actions supports it.

from redis.

I successfully transferred your changes.

No change in the errors.

Line 22 in connection.ipp where the error occurs was changed by your changes, but the first argument and the type of the first argument were not changed, which is what causes the error, only the second and third argument were changed.

Here is the version of my VS:

Microsoft Visual Studio Enterprise 2022
Version 17.8.3
VisualStudio.17.Release/17.8.3+34330.188
Microsoft .NET Framework
Version 4.8.09037

from redis.

I might be able to run the CI tests on my version of VS, but I first need to study the tests so I understand how and what it means if they pass or fail.

I can also try compiling src.hpp on VS version 19 to see if that works.

from redis.

I might be able to run the CI tests on my version of VS, but I first need to study the tests so I understand how and what it means if they pass or fail.

IIUC, we must first understand why you cannot build, running the tests are not necessary.

from redis.

I thought I had tested C++17 mode before, but I just retested.

Now when I flip the standard to C++17 instead of C++20, it compiles src.hpp . I flip back to C++20 and it stops compiling with the stated error. (That would mean no co routines).

[I added clickable expansions to some of the lengthy details above to make it more readable.]

Let me know if there is more required from me in reproducing this issue.

from redis.

Hi, are you using cmake? Can you copy here the exact command you are using to generate the cmake files? I had a look in the CI and the tools you are using a covered, for example

** Visual Studio 2022 Developer Command Prompt v17.8.3

###
### Using 'vc143' toolset.
###

I don't see what can be causing your issue.

from redis.

I am not using cmake. I downloaded the prebuilt Windows binaries, and added the boost include path to the include path of the project in question, at which point it fails if I have the language set to C++20, but not if I have the language set to C++17. It never gets close to linking when it fails. It fails during compilation due including src.hpp, the only thing being compiled.

from redis.

boostissue.zip
If you unzip this file it creates the directory boostissue which has boostredisfailure that contains Visual Studio 2022 solution/project and a single source file that #include's "boost/redis/src.hpp".

If you check out the latest version of boost into a boost directory in the boostissue directory, the rest of the dependencies are satisfied. I added the individual paths under libs to the include path until they were all satisfied, as well as the include directory of openssl.

If you compile this, as-is, you get the compiler error I reported above and one other I never saw before.

If you change the compiler to c++17 instead of c++20, then you see link errors, which is success because it means that the compilations succeeded and I didn't provide libraries to link against.

The error also seems to go away if you put it in non-permissive mode, which is an impossibility for large projects without many thousands of difficult fixes. I guess I will look at the option of compiling different files with different switches.

from redis.

Thanks.

I suppose this should be an issue for Microsoft, why are (incorrect?) errors raised when setting permissive mode, which should create fewer errors, not more. Unfortunately our experience with Microsoft Support is that it is generally not usable.

Now that I have provided the simple reproduction, I can understand if no one outside Microsoft chooses to do anything about this compilation failure. At the moment I have the work-around that I can set the one or multiple files in the project that call redis into strict/non-permissive mode which is good enough for now until we can migrate to a better platform.

from redis.