Giter VIP home page Giter VIP logo

Comments (6)

Lastique avatar Lastique commented on June 2, 2024

I don't have clang to test. @pdimov, would you like to take a look?

from winapi.

pdimov avatar pdimov commented on June 2, 2024

The smart_ptr-specific version of interlocked.hpp is at https://github.com/boostorg/smart_ptr/blob/develop/include/boost/smart_ptr/detail/sp_interlocked.hpp.

I don't remember all the intricacies of this - it's a pain of getting it to work on all the various configurations, each with its own quirks - so the best course of action is probably to just copy it over (removing the SP_ accordingly.)

Regarding use of intrin.h specifically, I see that the sp version would choose to use it when BOOST_MSVC >= 1600, which would be the case under Clang.

from winapi.

Lastique avatar Lastique commented on June 2, 2024

BOOST_MSVC is supposed to be only defined for genuine MSVC. It should not be defined for clang, should it?

from winapi.

pdimov avatar pdimov commented on June 2, 2024

You're right, it shouldn't be. Hm.

from winapi.

pdimov avatar pdimov commented on June 2, 2024

I confirm that the problem occurs with sp_interlocked.hpp as well. Should be fixed in boostorg/smart_ptr@4eb53db. I still couldn't figure out how to get clang-cl to work under b2 though.

from winapi.

Lastique avatar Lastique commented on June 2, 2024

Thanks, Peter. I've incorporated some of your changes in bf9dfd9. Hopefully, it fixes the problem.

from winapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.