Giter VIP home page Giter VIP logo

Comments (11)

jackherbert avatar jackherbert commented on May 26, 2024

Could you add the class navbar-left to the menu button and let me know if it helps?

<button type="button" class="navbar-toggle navbar-left" ...

from bootcards.

tomturner avatar tomturner commented on May 26, 2024

do you mean on

 <div class="navbar-header">
        <button type="button" class="navbar-toggle navbar-left" data-toggle="collapse" data-target=".navbar-collapse">
          <span class="sr-only">Toggle navigation</span>

As this still doesn't fix the issue

from bootcards.

jackherbert avatar jackherbert commented on May 26, 2024

My mistake, it might need to be on the other button - got my buttons mixed up!

<button type="button" class="btn btn-default btn-menu pull-left offCanvasToggle navbar-left ...

from bootcards.

tomturner avatar tomturner commented on May 26, 2024

No still didn't fix it

from bootcards.

jackherbert avatar jackherbert commented on May 26, 2024

It's strange because your markup looks more or less like the demo:
http://demo.bootcards.org/

That seems to be using a slightly earlier version of Bootcards – v1.1.0 – it might be worth trying that version in case a bug was introduced recently

from bootcards.

saschwarz avatar saschwarz commented on May 26, 2024

I'm seeing the same problem - it appears to have been introduced in 1.1.1. I noticed in 1.1.0 the button is absolutely positioned and it was changed to be relatively positioned.

from bootcards.

markleusink avatar markleusink commented on May 26, 2024

I've updated the demo app to 1.1.2. Menu button looks fine on iOS.

Only thing I do notice (on an iPhone) is that the header title is too far to the right.

from bootcards.

tomturner avatar tomturner commented on May 26, 2024

I converted my app back to v1.1.0 and it works fine.

I can get the same result as the demo with my app on v1.1.2. Until the header bug is fixed I won't upgrade

from bootcards.

saschwarz avatar saschwarz commented on May 26, 2024

It looks like it is dependent on the location of the .navbar-brand:
Bootcards
I moved mine outside of the .navbar-header (but still inside the .container) and the layout is correct using 1.1.2.

@tomturner it looks like we used the same template or example to get that layout; even though it isn't what is in the demo app or the current starter template.

from bootcards.

markleusink avatar markleusink commented on May 26, 2024

Correct, but the .navbar-brand title should be inside the .navbar-header block. The buttons should be inserted above the .navbar-brand and have the class navbar-left.

I added that missing navbar-left class to the docs, demo app and starter templates (see master branch). This is what the navbar should look like:

<div class="navbar navbar-default navbar-fixed-top" role="navigation">
  <div class="container">
    <div class="navbar-header">
      <button type="button" class="navbar-toggle" data-toggle="collapse" data-target=".navbar-collapse">
        <span class="sr-only">Toggle navigation</span>
        <span class="icon-bar"></span>
        <span class="icon-bar"></span>
        <span class="icon-bar"></span>
      </button>
    </div>

    <button type="button" class="btn btn-default btn-back navbar-left pull-left hidden" onclick="history.back()">
      <i class="fa fa-lg fa-chevron-left"></i>
      <span>Back</span>
    </button>
    <!-- menu button to show/ hide the off canvas menu -->
    <button type="button" class="btn btn-default btn-menu navbar-left pull-left" data-toggle="offcanvas">
      <i class="fa fa-lg fa-bars"></i><span>Menu</span>
    </button>

    <a class="navbar-brand" title="Bootcards Starter" href="/">Bootcards Starter</a>  

    <!--navbar menu options: shown on desktop only -->
    <div class="navbar-collapse collapse">
      <ul class="nav navbar-nav">
        <li>
        <a href="#">
          <i class="fa fa-dashboard"></i> Dashboard
        </a>
      </li>
      ...
    </ul>
  </div>          
</div>

from bootcards.

tomturner avatar tomturner commented on May 26, 2024

I can confirm this now works. Many thanks

from bootcards.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.