Giter VIP home page Giter VIP logo

Comments (9)

jlblancoc avatar jlblancoc commented on August 22, 2024

The latest git develop version of the example runs cleanly (even under Valgrind) when built in GCC.

What version of gtsam are you using?

from gtsam.

biggibig avatar biggibig commented on August 22, 2024

I just pulled down "develop" on Aug 08 2019.

The interesting thing is that ImuFactorExample seems to be working fine. I can even make the isam2 updater and use it. Trying to go the other way and try to use the LM updater in ImuFactorExample2 does not work, the same exception gets thrown.

from gtsam.

dellaert avatar dellaert commented on August 22, 2024

That's weird. Seems windows-related, maybe compiler that is more anal about RTTI. Could you investigate in a bit more detail what exactly the issue is?

from gtsam.

biggibig avatar biggibig commented on August 22, 2024

If I figure out the exact thing that breaks it, I'll let you know.

from gtsam.

ProfFan avatar ProfFan commented on August 22, 2024

#121

from gtsam.

biggibig avatar biggibig commented on August 22, 2024

I have a question about intended behavior of some of this stuff.

Let's say you have two 6DOF locations 2 priors, 1 binary factor. A situation where all values and factors have the same type obviously works.
initial(0) gets a Pose3; priorFactor(0) gets a Pose3;
initial(1) gets a Pose3, priorFactor(1) gets a Pose3;
betweenFactor(0,1) gets a Pose3;

You can change the Pose3 to a Rot3 for all of them and that still works.

Should I be able to mix and match types on the factors? Say by changing the second prior to a Rot3. As in

initial(0) gets Pose3; priorFactor(0) gets Pose3
initial(1) gets Pose3; priorFactor(1) gets Rot3
betweenFactor(0,1) gets a Pose3;

Is this scenario supposed to work? Because it's throwing the same exception for me.

from gtsam.

dellaert avatar dellaert commented on August 22, 2024

No, a prior factor needs to match the type of the variable. It is possible to have factors that only provide information about part of the variable (e.g., AttitudeFactor is an example), but that is not a β€œprior” on the variable in that case.

Could it be that this issue is not a GTSAM bug but rather the result of not being quite familiar yet with GTSAM and factor graphs? if so, please close the issue, read more (e.g. 2017 booklet by myself and Michael Kaess), and ask for help on Google Group - not via the GitHub issue system.

from gtsam.

biggibig avatar biggibig commented on August 22, 2024

Thanks that's exactly what I suspected.

The original issue is that the ImuFactorExample2 is throwing an exception on update after the IMU factor is added, without any modifications to the code on my part. Hence I needed to double check that the exception thrown by my simple dummy problem was in fact supposed to be thrown.

from gtsam.

ProfFan avatar ProfFan commented on August 22, 2024

Closing due to inactivity.

from gtsam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.