Glitches appearing on bezier corners about bemsimplelinegraph HOT 8 CLOSED

Hi @squarefrog,
Sorry for the late answer. This is indeed an issue and it's due to the way the graph is currently drawn (it uses multiple UIViews for each segment of the graph).
I'm currently working on a new way for it to be drawn, but it still requires more work as it changes a lot of things... The glitches won't be there anymore, and the performances should be better.
Thank you for pointing this out though!

from bemsimplelinegraph.

Can I ask why you're drawing each segment unsteady of just doing multiple UIBezierPath?

Not a criticism, just genuinely intrigued!

from bemsimplelinegraph.

Of course!
I thought that it would give me more control for certain things. For example it makes it easier to have methods like lineColorForIndex.
But performance wise it's pretty bad, and it creates bug like the one you spotted (at first the graph didn't have Bézier curves, so the issue wasn't here).
Now it's not easy to move back to drawing the graph differently without breaking a bunch of stuff. But I'm making good progress!

from bemsimplelinegraph.

Thanks for explaining; I always appreciate hearing other developers thought processes. 👍

from bemsimplelinegraph.

Hi @squarefrog,
I pushed a new commit to the feature branch yesterday that should fix the glitch issue. The graph is now drawn as one line instead of segments.
Please note that this branch is not as stable. A few features like lineColorForIndex are broken for now.
Thank you for opening this issue.

from bemsimplelinegraph.

Any idea when this will be pushed to the master branch? I have been experiencing extreme performance issue...

from bemsimplelinegraph.

You're very welcome!

from bemsimplelinegraph.

Hi @FrederickGeek8,
I need to test the feature branch a little bit more before merging it to the master one. There are a few things that I need to fix too. So I don't think it will happen in the next coming days.
Did you try using the build on the feature branch? If so, did you see any improvement performance wise?
Also, may I ask how to repro your performance issue?
Thanks for the feedback!

from bemsimplelinegraph.