Giter VIP home page Giter VIP logo

Comments (5)

Boris-Em avatar Boris-Em commented on July 18, 2024

@Sam-Spencer
Thanks a lot for your work on this feature! It looks great!
The starting position of the vertical reference lines and the position of the horizontal frame line are now calculated in function of the height of the labels on the X-Axis (see commit 80a65ae).

from bemsimplelinegraph.

ManuelRiegler avatar ManuelRiegler commented on July 18, 2024

support for Y-Axis reference lines would be really great ..I am not quite sure if some on startet to work on it out of closed issue #30 discussion

from bemsimplelinegraph.

Boris-Em avatar Boris-Em commented on July 18, 2024

Hi @AskinOharis,
From #30, It looks like @japanconman started working on the support for Y-Axis reference lines.

from bemsimplelinegraph.

japanconman avatar japanconman commented on July 18, 2024

@Sam-Spencer @Boris-Em
The offset issues should be fixed. Potential crash when BEMSimpleLineGraphView enableYAxisLabelOffset = YES is patched as well.

But I think I might have miss out adding in the offset to the special case handling in X-Axis (e.g. numberOfPoints = 1)

from bemsimplelinegraph.

Sam-Spencer avatar Sam-Spencer commented on July 18, 2024

@AskinOharis @japanconman @Boris-Em UPDATE: Both the X-Axis reference lines and Y-Axis reference lines are fully supported on the feature branch. See commit df2ba28.

from bemsimplelinegraph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.