ArmCord - Version Mismatch about pi-apps HOT 15 CLOSED

yes, I just told my system to update bash sudo apt upgrade bash and it updated google-chrome since it was upgradable currently.....

from pi-apps.

Hello there 👋
Thanks for submitting your first issue to the Pi-Apps project! We'll try to get back to you as soon as possible.
In the meantime, we encourage you join our Discord server, where you can ask any questions you might have.

Please respond as soon as possible if a Pi-Apps maintainer requests more information from you. Stale issues will be closed after a lengthy period of time with no response.

from pi-apps.

I don't think it is pi-apps. our scripts are up to date
https://github.com/Botspot/pi-apps/blob/master/apps/ArmCord/install-32
https://github.com/Botspot/pi-apps/blob/master/apps/ArmCord/install-64

send all install/uninstall logs in ~/pi-apps/logs/ folder for armcord here

from pi-apps.

I don't think it is pi-apps. our scripts are up to date
https://github.com/Botspot/pi-apps/blob/master/apps/ArmCord/install-32
https://github.com/Botspot/pi-apps/blob/master/apps/ArmCord/install-64

send all install/uninstall logs in ~/pi-apps/logs/ folder for armcord here

logs.zip

from pi-apps.

your armcord package is marked as manually install because as you said you manually installed it before.
this prevents pi-apps from uninstalling it in the first place since you manually installed it.

what version does apt report as installed? apt list armcord

from pi-apps.

your armcord package is marked as manually install because as you said you manually installed it before.
this prevents pi-apps from uninstalling it in the first place since you manually installed it.

what version does apt report as installed? apt list armcord

Ah yeah, I see it shows the older version installed:

Listing... Done
armcord/now 3.1.3 arm64 [installed,local]

from pi-apps.

Shouldn't there be a better warning or disclaimer when something like this is happening?

from pi-apps.

@Botspot not sure what do to about this.
pin priorities are no help because those only affect the software if it is not currently installed.

the only solution I have is modifying the dummy deb to include a >= the version of any downloaded file or local package

from pi-apps.

install_packages or purge_packages could mark local debs as automatically installed.

from pi-apps.

I've already explained why that would be bad multiple times before. thats not an option.

I'm working on this #2395 (comment) rn. its not hard and should be fine.

from pi-apps.

I've already explained why that would be bad multiple times before. thats not an option.

I could be mistaken, but in the past my bad suggestion was to mark all packages wanted by the dummy deb as auto, but this time I was suggesting to only mark locally downloaded packages as auto.

Potential problems with changing dummy debs to require the latest version of a local package:

1. It could break other areas in the api where details of the dummy deb are parsed. Namely, I'm thinking of the code that checks the dummy deb's current list of dependencies. That code would need to be tested in all cases to handle the added version numbers.
2. It would prevent the user from manually installing an older version of the local package, to troubleshoot an issue. The dummy deb would first need to be uninstalled.

Maybe instead install_packages could detect this situation and during the time when the local apt repository is still set up, it could run sudo apt upgrade armcord.

from pi-apps.

1. It could break other areas in the api where details of the dummy deb are parsed. Namely, I'm thinking of the code that checks the dummy deb's current list of dependencies. That code would need to be tested in all cases to work with added version numbers.

good point. get_icon_from_package will need to be updated to remove the version number when checking with dpkg-query for the icon

2. It would prevent the user from manually installing an older version of the local package, to troubleshoot an issue. The dummy deb would first need to be uninstalled.

sounds like a feature to me

Maybe instead install_packages could detect this situation and during the time when the local apt repository is still set up, it could run sudo apt upgrade armcord.

I don't like that solution as much since we would need to first parse all depends then pass them it to sudo apt install --upgrade-only (sudo apt upgrade armcord is invalid syntax, upgrade does not take any package names as arguments, it just ignores them and does a regular upgrade). Also adding an additional upgrade command will slow down installs.

from pi-apps.

1. It could break other areas in the api where details of the dummy deb are parsed. Namely, I'm thinking of the code that checks the dummy deb's current list of dependencies. That code would need to be tested in all cases to work with added version numbers.

good point. get_icon_from_package will need to be updated to remove the version number when checking with dpkg-query for the icon

nevermind, it is already good because of the awk '{print $1}' that is already included.
so no futher changes necessary

from pi-apps.

good point. get_icon_from_package will need to be updated to remove the version number when checking with dpkg-query for the icon

get_icon_from_package is not normally used on dummy debs...

(sudo apt upgrade armcord is invalid syntax, upgrade does not take any package names as arguments, it just ignores them and does a regular upgrade)

Are you sure?

$ sudo apt upgrade chromium-browser
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
chromium-browser is already the newest version (113.0.5672.95-rpt1).
Calculating upgrade... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

from pi-apps.

As a side affect of the PR, I think it is also nice to see the versions listed out to the user.

Allowing packages required by the ArmCord app to be uninstalled
These packages were: armcord (>= 3.2.1)

the >= system is widely used in debian in metapackages (what our dummy debs are), I see it as appropriate here.

from pi-apps.