Giter VIP home page Giter VIP logo

Comments (33)

github-actions avatar github-actions commented on July 2, 2024

A zipfile was found in the body of your issue.
The sha1sum of the zip was: a0af1bba48175d0b6f11b1ca1bcc4cfd377e9f00

Click to show contents preview

OpenStream Music/uninstall

#!/bin/bash

#Allow packages required by this app to be uninstalled
purge_packages || exit 1

OpenStream Music/install-32

#!/bin/bash

version=1.2.0

install_packages https://github.com/openstreamorg/openstreammusic/releases/download/v${version}/openstreammusic_${version}_armv7l.deb || error 'Failed to install OpenStream Music'

OpenStream Music/install-64

#!/bin/bash

version=1.2.0

install_packages https://github.com/openstreamorg/openstreammusic/releases/download/v${version}/openstreammusic_${version}_arm64.deb || error 'Failed to install OpenStream Music'

OpenStream Music/description

Freeing the world of 'freemium' streaming services.
OpenStream Music is the only free, open source, accounts free and even ad free streaming service in the whole world! Doesn't that feel good?
To open OpenStream Music on your Pi, open the menu and go to the 'Sound & Video' section, where you will spot 'OpenStream Music'

OpenStream Music/website

https://openstreamorg.github.io

from pi-apps.

github-actions avatar github-actions commented on July 2, 2024

Hello there 👋
Thanks for submitting your first issue to the Pi-Apps project! We'll try to get back to you as soon as possible.
In the meantime, we encourage you join our Discord server, where you can ask any questions you might have.

Please respond as soon as possible if a Pi-Apps maintainer requests more information from you. Stale issues will be closed after a lengthy period of time with no response.

from pi-apps.

Botspot avatar Botspot commented on July 2, 2024

Are there openstream servers providing cached music, or does this use something like youtube-dl or yt-dlp as the backend?
The reason I ask is because I once wrote a program like this called PiTunes - it was never finished it but it was a very similar idea.

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

It uses ytdl (a node frontend for YouTube-DL)

EDIT: We don't have servers so it's easier to do it on the client side.

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

You could contribute some features from PiTunes if you wanted?

from pi-apps.

Botspot avatar Botspot commented on July 2, 2024

You could contribute some features from PiTunes if you wanted?

PiTunes is all a bash script. Most of the code was to handle a playlist behavior with random ordering, editing, automatically splitting songs based on timestamps found in the description, and allowing manual trimming of each audio segment. It also had a simple scripting language for importing other people's playlists. I doubt any of that could transfer over to a project written in node.

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

I was only meaning suggestions. Are you merging or closing?

from pi-apps.

theofficialgman avatar theofficialgman commented on July 2, 2024

It is a free and open source music streaming service that has no ads or accounts. It uses its own database or YouTube Music's if it doesn't have the song.

To me this sounds like a GUI frontend for piracy. You need to explain what is included in your database, where you steam those files from, and what license you have for that media where applicable.

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

You cannot download anything.
They come directly from Google's servers.

What's your opinion on Youtubuddy then? It's the same concept.

from pi-apps.

theofficialgman avatar theofficialgman commented on July 2, 2024

You cannot download anything. They come directly from Google's servers.

What's your opinion on Youtubuddy then? It's the same concept.

You did not define what the "own database" is. That is what I was asking about.

Streaming from YouTube using their API is already proven legal (in the US at least) and there isn't any debate about that. I was not asking about that part though.

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

It's a json file with links to some mp3s.
It's currently in progress to remove as we now use YT Music.

from pi-apps.

Botspot avatar Botspot commented on July 2, 2024

It seems that user techguy16 is giving us minimal information. (spoonfeeding)
It's okay. You're welcome to go in depth. We can handle it. @techguy16, please explain the full flow of information - like how the user picks songs, how they are served up, how the audio is downloaded, and from where, and how it is stored, and if you have thought through legal implications like the situation youtube-dl had to undergo.

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

The user can choose from the "database" JSON that we have (set to be removed soon) on the homepage or search YouTube Music.
It then searches YouTube Music for that song. After that YTDL-Core gets the mp3 url and streams it if the song is clicked. The audio cannot be downloaded from YT Music, so you can only play it.
As of now I'm currently working on scrubbing cache after a song is played.

from pi-apps.

theofficialgman avatar theofficialgman commented on July 2, 2024

One thing I notice quickly is the ancient version of electron used.
This is very dangerous given that your application loads images and is vulnerable to the webp CVE (and many others)
https://github.com/openstreamorg/openstreammusic/blob/b7a8a108e1d684cb2670da4162358f062539e5a5/desktop/package-lock.json#L4164-L4174

Please use one of the actively supported stable electron releases https://releases.electronjs.org/

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

Hey @theofficialgman, in 1.3 I'm updating it to Electron 22 so I can still support Win7 but patch many security issues. (Commit f23ea5a)

And the bit about YouTube-DL and the legal stuff, it's not my problem. If the ytdl-core project dies, the Internet Archive it is.

from pi-apps.

theofficialgman avatar theofficialgman commented on July 2, 2024

Hey @theofficialgman, in 1.3 I'm updating it to Electron 22 so I can still support Win7 but patch many security issues. (Commit f23ea5a)

22 is also EOL as of 2+ weeks ago so that isn't enough. People have had years of extra time to move off of that platform. Sorry it's time to let that OS support die.

If you want to support windows 7, don't use a browser as your GUI toolkit.

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

Supply a separate build for Win7?

from pi-apps.

Botspot avatar Botspot commented on July 2, 2024

Supply a separate build for Win7?

That is up to you, @techguy16.

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

What I'm now doing:

  • Windows 7&8 and 10&11 have a separate build (npm run install-app-deps-win7 for Windows 7 and npm run install-app-deps for 10&11)
  • Linux uses the latest Electron version.

Please wait until 1.3 is release before merging (only if you are).

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

Updated to Version 1.3

from pi-apps.

github-actions avatar github-actions commented on July 2, 2024

A zipfile was found in the body of your issue.
The sha1sum of the zip was: 4e60afebc87b1b2dc8fd0083324c9e3d1717b0fe

Click to show contents preview

OpenStream Music/description

Freeing the world of 'freemium' streaming services.
OpenStream Music is the only free, open source, accounts free and even ad free streaming service in the whole world! Doesn't that feel good?
To open OpenStream Music on your Pi, open the menu and go to the 'Sound & Video' section, where you will spot 'OpenStream Music'

OpenStream Music/website

https://openstreamorg.github.io

OpenStream Music/install-32

#!/bin/bash

version=1.3.0

install_packages https://github.com/openstreamorg/openstreammusic/releases/download/v${version}/openstreammusic_${version}_armv7l.deb || error 'Failed to install OpenStream Music'

OpenStream Music/install-64

#!/bin/bash

version=1.3.0

install_packages https://github.com/openstreamorg/openstreammusic/releases/download/v${version}/openstreammusic_${version}_arm64.deb || error 'Failed to install OpenStream Music'

OpenStream Music/uninstall

#!/bin/bash

#Allow packages required by this app to be uninstalled
purge_packages || exit 1

from pi-apps.

theofficialgman avatar theofficialgman commented on July 2, 2024

OpenStream Music/website

https://openstreamorg.github.io

the linked website does not exist/work

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

@theofficialgman it's the homepage for OpenStream, the organization that "owns" OpenStream Music.
It does work by the way.

from pi-apps.

theofficialgman avatar theofficialgman commented on July 2, 2024

it is a very good and descriptive homepage if it is working as intended
image

from pi-apps.

Botspot avatar Botspot commented on July 2, 2024

The site is working for me.

from pi-apps.

Sussy-OS avatar Sussy-OS commented on July 2, 2024

it is a very good and descriptive homepage if it is working as intended image

It works for me as well. It must be an issue on your end.

from pi-apps.

theofficialgman avatar theofficialgman commented on July 2, 2024

manually changed to http
got some info

image

currently on university connection.... I doubt it was manually blocked. Something on their scraper must have found something phishy on the webpage. Was this domain owned before by something else maybe?

from pi-apps.

Botspot avatar Botspot commented on July 2, 2024

@techguy16, I have given OpenStream a try. It looks good in some ways. As a test user, I found some issues and opened some support issues on your github. https://github.com/openstreamorg/openstreammusic/issues

After my review, I concluded that currently OpenStream seems to still be in alpha stage - with significant issues present. My recommendation is to get the app to a high level of "functional" before it is added to the largest ARM Linux app store.

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

@Botspot, 2.0 is on the cards, which is a major revamp and fixes lots.
It is designed for Pi 4's and up, even though it runs on my Pi 3B+.
Thank you for your time and trying OpenStream Music. I see some of the issues are quick fixes, so I'll get onto them pretty soon.

from pi-apps.

Botspot avatar Botspot commented on July 2, 2024

@techguy16, have you dropped work on this?

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

No, I've just got distracted with other random things 😀 (Such as LinStore, which competes with Pi-Apps, don't get angry)

from pi-apps.

Botspot avatar Botspot commented on July 2, 2024

Should I just go ahead and close this issue then?

from pi-apps.

techguy16 avatar techguy16 commented on July 2, 2024

For now, I'll get back eventually (hopefully...)

from pi-apps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.