Comments (7)
Thanks for the heads-up. We're fine with switching to your deb release. Do you have your own apt repo? If not, that's fine.
This looks like a very simple change. Pi-Apps' main strength is its flexibility. It's a script, so any app can install by any means necessary.
While I could go ahead and make these changes myself, it would probably save us both time if you opened a pull request with the proposed changes. and yes, it looks like a copy of the FreeTube scripts would be a great starting point. This also gives you the chance to shoutout the new features in the description. If you can't tell, I think PiGro is pretty awesome especially for intermediate users who want to get stuff done quickly.
from pi-apps.
@actionschnitzel I would prefer that you package your deb properly if we are to switch to it.
you should not be using prerm, postrm, and postinst scripts to create/delete a /usr/share/applications/pigro.desktop
file or modify permissions of any files that were just installed. Permissions should be corrected in the data archive itself and all files should be present in that. Right now your deb is very hacky for no reason.
The owner of the files is also incorrect in the data archive as well. The files are owned by the user "timo" when they should be "root" owned.
from pi-apps.
@theofficialgman Wow, good that you've taken a closer look. I am using a script that I found. Must fix this as soon as possible.
from pi-apps.
Update:
I fixed the ownership and permissions for pigro-jci-23.04.deb
and also created a proper directory structure. I hope everything is now as it should be. If not, just let me know.
Thanks to both of you for your help and constructive criticism. It's appreciated.
Once everything is ready, I will create a pull request.
from pi-apps.
Update: I fixed the ownership and permissions for
pigro-jci-23.04.deb
and also created a proper directory structure. I hope everything is now as it should be. If not, just let me know.
Much better.
One thing to note about your .desktop file. You shouldn't need to specify the full path to the icon for it to work
Icon=/usr/share/icons/hicolor/256x256/apps/pigro-logo.png
. Just the name of the icon should do Icon=pigro-logo
. That lets users who have custom themed icons easily overwrite yours without having to edit the .desktop file manually. Additionally, if you have vectored versions of your logo that is generally a good thing to provide as well, they go under /usr/share/icons/hicolor/scalable/apps
as an .svg
file.
Yes I realize that this icon only gets used briefly during launch of your application before the main python script tells tkinter to use a specific hardcoded icon but it is still good practice. I will let you play around with the python code and see if you can get away with not specifying the full path and still have the icon load there as well.
from pi-apps.
"It's always good to be nudged in the right direction :-) The .svg
is now included. I replaced "self.iconphoto(True, self.icon)
" (still needs to be completely removed) with "__init__(className="PiGro")
". One less thing giving me a headache!
I've packed v23.04 and a DEV-Preview of v24.01... Just in case there's interest."
PIGRO-DEBS.tar.gz
from pi-apps.
"It's always good to be nudged in the right direction :-) The
.svg
is now included. I replaced "self.iconphoto(True, self.icon)
" (still needs to be completely removed) with "__init__(className="PiGro")
". One less thing giving me a headache!
Right yeah, regarding the className variable, wayland based compositors actually can't set the window/titlebar icon through the old methods used in X11. What wayland compositors (like wayfire) do to get around this is check the class
(and sometimes other environment variables) and see what .desktop files have a matching StartupWMClass
or filename. the checks are different depending on the DE (eg: piOS wayfire, gnome, kde) and can be a little fuzzy so what works in one DE might not work in another (eg: some are case sensitive, others are not). I checked your deb and what you did looks good. That should work on everything since matching the set env variable class
with the .desktop files StartupWMClass
is the most supported case.
from pi-apps.
Related Issues (20)
- Failed to install Chiaki HOT 2
- Telegram Desktop unable to launch HOT 3
- Add script install app Qalculate! to Pi-Apps HOT 6
- obsidian rendering issues HOT 2
- Attempting install, pi-apps will not exec from Start menu & returns errors via command-line installation HOT 5
- Arduino IDE 2.x (for ARM64) HOT 13
- Suggestion enchantment add box86wine to RetroPie HOT 2
- Numbat: Install based app HOT 13
- Gdevelop HOT 6
- Libresprite HOT 3
- incorrect error diagnosis HOT 6
- Need help with broken apt HOT 3
- Matrix group HOT 3
- GDL Launcher: Error: Uncaught Fatal Exception; code: 1 HOT 3
- Roblox? HOT 2
- Web cloning you may have security problems on your official Raspberry PI App installation HOT 2
- Freetube does not show up in bookworm 32 bit (Microsoft Surface RT) HOT 6
- Vulkan Drivers! (Install based app) HOT 5
- Hyper app not opening HOT 7
- XSnow Failed to install for an Unknown reason (on raspberry pi 5 Debain 12) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pi-apps.