Giter VIP home page Giter VIP logo

Comments (9)

Botspot avatar Botspot commented on September 23, 2024 1

Let's transition them and keep the name the same.

from pi-apps.

github-actions avatar github-actions commented on September 23, 2024

Hello there 👋
Thanks for submitting your first issue to the Pi-Apps project! We'll try to get back to you as soon as possible.
In the meantime, we encourage you join our Discord server, where you can ask any questions you might have.

Please respond as soon as possible if a Pi-Apps maintainer requests more information from you. Stale issues will be closed after a lengthy period of time with no response.

from pi-apps.

theofficialgman avatar theofficialgman commented on September 23, 2024

regarding https://github.com/l-koehler/FF-converter?tab=readme-ov-file#troubleshooting that is a known issue with pipx, it doesn't have the ability to install .desktop files and was deemed "out of the project scope" (see pypa/pipx#717)

it is easy to copy the file out of the installed directory though and place it in the proper location since it does reside in the pipx installed directory similar to what we do for Quartz

# add .desktop symlinks since pipx does not create them https://github.com/pypa/pipx/issues/717
sudo mkdir -p /usr/local/share/applications /usr/local/share/icons
sudo ln -sf /usr/local/pipx/venvs/quartz-browser/share/applications/quartz-browser.desktop /usr/local/share/applications/quartz-browser.desktop
sudo ln -sf /usr/local/pipx/venvs/quartz-browser/share/icons/quartz-browser.png /usr/local/share/icons/quartz-browser.png

from pi-apps.

l-koehler avatar l-koehler commented on September 23, 2024

thanks!
added that to the install instructions, as the previous workaround didn't work with the icon.

from pi-apps.

theofficialgman avatar theofficialgman commented on September 23, 2024

@Botspot what are your thoughts on this? should we deprecate FF Multi Converter and instruct users in the popup to install FF Converter or should we simply change the scripts to install FF Converter while keeping the name?

from pi-apps.

l-koehler avatar l-koehler commented on September 23, 2024

@theofficialgman
thanks for the update!
small problem: the install script is not automatically installing all optional dependencies.
the fork can also use pandoc, ar, zip and squashfs-tools. (tar too, but that should be preinstalled).
also, maybe it should only fail if python3 or pyqt5 fail to install, not if a optional dependency fails.
i would suggest to replace line 12 with

install_packages python3 python3-pyqt5 python3-distutils || exit 1
install_packages tar ar squashfs-tools pandoc ffmpeg imagemagick unoconv || echo "Could not install all optional dependencies"

(not sure about what pi-apps uses to show non-fatal errors, might need to replace the echo)

from pi-apps.

theofficialgman avatar theofficialgman commented on September 23, 2024

@l-koehler we can install all packages that are available. there isn't any downside for having all the dependencies installed even if they are optional. with them installed the software has more features.

what is the ar that you are referring to? that isn't a package name and the binary under that name is from binutils and is the GNU assembler which I don't think you meant to write.

from pi-apps.

l-koehler avatar l-koehler commented on September 23, 2024

Part of binutils, shouldn't need install on most distributions.

A utility for creating, modifying and extracting from archives.

Don't know why I included it, i guess it was missing for me once.

from pi-apps.

theofficialgman avatar theofficialgman commented on September 23, 2024

The dependencies suggested have been added

from pi-apps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.