Adding disk causes VM to be re-created about terraform-provider-proxmox HOT 6 CLOSED

Thanks for confirming, @zarinbal, and for offering help!

The disk management part in the provider is quite messy, especially when cloning templates. There are few open tickets for disks, and they are related to each other. On top of that there are dozens of use cases that provider needs to support, so we need to be careful making changes there.
I really need to set some time aside and think about reorganizing this part...

But please vote with 👍🏼 on the ticket to rise its priority.

from terraform-provider-proxmox.

Same problem

i tried to add or remove disk

resource "proxmox_virtual_environment_vm" "k8s_master_1" {
  vm_id               = 120
  name                = "k8s-master-1"
  node_name           = "prxmx"
  acpi                = true
  bios                = "seabios"
  boot_order          = null
  description         = null
  migrate             = false
  on_boot             = true
  reboot              = false
  scsi_hardware       = "virtio-scsi-pci"
  started             = true
  stop_on_destroy     = null
  tablet_device       = true
  tags                = []
  template            = false
  lifecycle {
   # prevent_destroy = true
  }
  cpu {
    architecture = "x86_64"
    cores        = 4
    flags        = []
    hotplugged   = 0
    limit        = 0
    numa         = true
    sockets      = 1
    type         = "host"
    units        = 1024
  }
  clone {
    vm_id = 1001
  }
  agent {
    enabled = true
    timeout = "15m"
    trim    = false
    type    = "virtio"
  }
  disk {
    cache             = "none"
    datastore_id      = "local-lvm"
    discard           = "ignore"
    file_format       = "raw"
    interface         = "scsi0"
    iothread          = false
    size              = 25
    ssd               = false
  }
  disk {
    cache             = "none"
    datastore_id      = "local-lvm"
    discard           = "ignore"
    file_format       = "raw"
    interface         = "scsi1"
    iothread          = false
    size              = 20
    ssd               = false
  }
  initialization {
    datastore_id         = "local-lvm"
    interface            = "ide2"
    ip_config {
      ipv4 {
        address = "10.0.0.120/24"
        gateway = "10.0.0.1"
      }
    }
  }
  memory {
    dedicated = 2048
    floating  = 0
    shared    = 0
  }
  network_device {
    bridge      = "vmbr0"
    enabled     = true
    firewall    = false
    model       = "virtio"
    mtu         = 0
    queues      = 0
    rate_limit  = 0
    vlan_id     = 0
  }
  serial_device {
    device = "socket"
  }
}

and then terraform tries to delete and recreate the VM.

i use latest version

version = "0.44.0"

from terraform-provider-proxmox.

still valid

from terraform-provider-proxmox.

Hello,

I've encountered similar issue with the provider when removing disks from a template.

Steps to Reproduce:

1. Initial Configuration: Add two disks to the template as follows:

   # Disk 1: Boot
   disk {
     datastore_id = "fast"
     discard = "on"
     file_format = "raw"
     file_id = "shared-iso:iso/ubuntu-22.04-cloudimg-amd64-raw.img"
     interface = "scsi0"
     iothread = false
     size = 20
     ssd = true
   }
   # Disk 2: Data
   disk {
     cache = "none"
     datastore_id = "fast"
     discard = "on"
     file_format = "raw"
     interface = "scsi1"
     iothread = false
     size = 15
     ssd = true
   }``` 
   

2. Removing a Disk:
   Attempting to remove a disk (e.g., the second disk) results in the template trying to recreate itself instead of just removing the specified disk. (See attached screenshot:

Expected Behavior:
The template should allow adding or removing a specified disk without attempting to recreate the entire VM.

I'm unsure whether to open a new issue for this or if it fits within the scope of the current one. Additionally, I'm willing to assist in resolving this issue; any guidance on contributing would be greatly appreciated.

Thank you

from terraform-provider-proxmox.

Awesomely detailed bug report, thanks!

from terraform-provider-proxmox.

Marking this issue as stale due to inactivity in the past 180 days. This helps us focus on the active issues. If this issue is reproducible with the latest version of the provider, please comment. If this issue receives no comments in the next 30 days it will automatically be closed. If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

from terraform-provider-proxmox.