Describe the bug Following the VM creation example with a .tar.xz

This really gnarly code is responsible for disk creation: <div class="Box Box--con

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

proxmox_virtual_environment_vm does not use proper path from proxmox_virtual_environment_file about terraform-provider-proxmox HOT 2 CLOSED

bpg commented on August 9, 2024 1

proxmox_virtual_environment_vm does not use proper path from proxmox_virtual_environment_file

from terraform-provider-proxmox.

Comments (2)

bpg commented on August 9, 2024 1

This really gnarly code is responsible for disk creation:

terraform-provider-proxmox/proxmoxtf/resource_virtual_environment_vm.go

Lines 1993 to 2016 in 3c02cb1

 `set -e`, 

 fmt.Sprintf(`datastore_id_image="%s"`, fileIDParts[0]), 

 fmt.Sprintf(`datastore_id_target="%s"`, datastoreID), 

 fmt.Sprintf(`disk_index="%d"`, i), 

 fmt.Sprintf(`disk_options="%s"`, diskOptions), 

 fmt.Sprintf(`disk_size="%d"`, size), 

 fmt.Sprintf(`disk_interface="%s"`, diskInterface), 

 fmt.Sprintf(`file_path="%s"`, filePath), 

 fmt.Sprintf(`file_path_tmp="%s"`, filePathTmp), 

 fmt.Sprintf(`vm_id="%d"`, vmID), 

 `getdsi() { local nr='^([A-Za-z0-9_-]+): ([A-Za-z0-9_-]+)$'; local pr='^[[:space:]]+path[[:space:]]+([^[:space:]]+)$'; local dn=""; local dt=""; while IFS='' read -r l || [[ -n "$l" ]]; do if [[ "$l" =~ $nr ]]; then dt="${BASH_REMATCH[1]}"; dn="${BASH_REMATCH[2]}"; elif [[ "$l" =~ $pr ]] && [[ "$dn" == "$1" ]]; then echo "${BASH_REMATCH[1]};${dt}"; break; fi; done < /etc/pve/storage.cfg; }`, 

 `dsi_image="$(getdsi "$datastore_id_image")"`, 

 `dsp_image="$(echo "$dsi_image" | cut -d ";" -f 1)"`, 

 `dst_image="$(echo "$dsi_image" | cut -d ";" -f 2)"`, 

 `if [[ -z "$dsp_image" ]]; then echo "Failed to determine the path for datastore '${datastore_id_image}' (${dsi_image})"; exit 1; fi`, 

 `dsi_target="$(getdsi "$datastore_id_target")"`, 

 `dsp_target="$(echo "$dsi_target" | cut -d ";" -f 1)"`, 

 `cp "${dsp_image}${file_path}" "$file_path_tmp"`, 

 `qemu-img resize "$file_path_tmp" "${disk_size}G"`, 

 `imported_disk="$(qm importdisk "$vm_id" "$file_path_tmp" "$datastore_id_target" -format qcow2 | grep "unused0" | cut -d ":" -f 3 | cut -d "'" -f 1)"`, 

 `disk_id="${datastore_id_target}:$([[ -n "$dsp_target" ]] && echo "${vm_id}/" || echo "")$imported_disk$([[ -n "$dsp_target" ]] && echo ".qcow2" || echo "")${disk_options}"`, 

 `qm set "$vm_id" "-${disk_interface}" "$disk_id"`, 

 `rm -f "$file_path_tmp"`, 

 )

It doesn't know anything about special handling of vztmpl content type 😞. Without much of unit tests any change there is kind of open heart surgery, but let me see what can be done. It seems that pvesm can replace most of the custom getdsi() logic over there, so I have some hope.

I would really appreciate any help with testing the fix when it will be available, on as many different storage types as possible.

from terraform-provider-proxmox.

bpg commented on August 9, 2024

Hi @fpicot! 👋🏼
I think #241 should fix this particular issue, although i'm not sure if the image you're trying to create VM from is the right one. I wasn't able to boot the VM using a "raw" disk from that image.
Have you had any success with any of non-qcow2 images for VMs on proxmox?

EDIT: I guess my comment is more related to #188 issue 😅

from terraform-provider-proxmox.

Recommend Projects

proxmox_virtual_environment_vm does not use proper path from proxmox_virtual_environment_file about terraform-provider-proxmox HOT 2 CLOSED

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	`set -e`,
	fmt.Sprintf(`datastore_id_image="%s"`, fileIDParts[0]),
	fmt.Sprintf(`datastore_id_target="%s"`, datastoreID),
	fmt.Sprintf(`disk_index="%d"`, i),
	fmt.Sprintf(`disk_options="%s"`, diskOptions),
	fmt.Sprintf(`disk_size="%d"`, size),
	fmt.Sprintf(`disk_interface="%s"`, diskInterface),
	fmt.Sprintf(`file_path="%s"`, filePath),
	fmt.Sprintf(`file_path_tmp="%s"`, filePathTmp),
	fmt.Sprintf(`vm_id="%d"`, vmID),
	`getdsi() { local nr='^([A-Za-z0-9_-]+): ([A-Za-z0-9_-]+)$'; local pr='^[[:space:]]+path[[:space:]]+([^[:space:]]+)$'; local dn=""; local dt=""; while IFS='' read -r l \|\| [[ -n "$l" ]]; do if [[ "$l" =~ $nr ]]; then dt="${BASH_REMATCH[1]}"; dn="${BASH_REMATCH[2]}"; elif [[ "$l" =~ $pr ]] && [[ "$dn" == "$1" ]]; then echo "${BASH_REMATCH[1]};${dt}"; break; fi; done < /etc/pve/storage.cfg; }`,
	`dsi_image="$(getdsi "$datastore_id_image")"`,
	`dsp_image="$(echo "$dsi_image" \| cut -d ";" -f 1)"`,
	`dst_image="$(echo "$dsi_image" \| cut -d ";" -f 2)"`,
	`if [[ -z "$dsp_image" ]]; then echo "Failed to determine the path for datastore '${datastore_id_image}' (${dsi_image})"; exit 1; fi`,
	`dsi_target="$(getdsi "$datastore_id_target")"`,
	`dsp_target="$(echo "$dsi_target" \| cut -d ";" -f 1)"`,
	`cp "${dsp_image}${file_path}" "$file_path_tmp"`,
	`qemu-img resize "$file_path_tmp" "${disk_size}G"`,
	`imported_disk="$(qm importdisk "$vm_id" "$file_path_tmp" "$datastore_id_target" -format qcow2 \| grep "unused0" \| cut -d ":" -f 3 \| cut -d "'" -f 1)"`,
	`disk_id="${datastore_id_target}:$([[ -n "$dsp_target" ]] && echo "${vm_id}/" \|\| echo "")$imported_disk$([[ -n "$dsp_target" ]] && echo ".qcow2" \|\| echo "")${disk_options}"`,
	`qm set "$vm_id" "-${disk_interface}" "$disk_id"`,
	`rm -f "$file_path_tmp"`,
	)