Comments (12)
Thanks for checking it out! I applied the patch and added you as a contributor - really great reference for what I can improve on and conventions to follow. I'll do a bit more testing, I'm a little concerned around the default value set to 4G. I'm not quite sure how LXC images are created/deployed but if the base image to deploy is larger than 4G we may hit a snag so I'll see what I can do around that or if it's an issue that we run in to. I based that just off the LXCs that I've created from defaults they were all 4G.
Then I'll update the docs in either direction that goes and PR!
from terraform-provider-proxmox.
I'd love to see this merged soon as it's pretty much the only thing that limits functionality vs the other provider.
from terraform-provider-proxmox.
Howdy, just FYI, I don't know GO directly but am learning as I go and forked to start working on this: https://github.com/DacoDev/terraform-provider-proxmox-dacofork
From digging around, it looks like some of the resources that will be needed for this already exist. Just don't want to duplicate efforts or if you have any suggestions the repo is public.
from terraform-provider-proxmox.
Awesome! I'll try to take a look in the next few days.
from terraform-provider-proxmox.
@DacoDev Thanks for the code!
I've made a few changes on top of your main branch, here is the patch: Fix_RootFS_parameters_handling.patch.zip
(or if you add me as a contributor to your repo I can make a PR there)
The changes seems to be working, here is an example container from my test env:
The only remaining part is documentation update -- add rootfs_size
param under disk
in docs/resources/virtual_environment_container.md.
Then feel free to open a PR!
from terraform-provider-proxmox.
Sorry for the delay on getting this back, I ran into issues while spinning up a container, it wasn't actually receiving or recognizing the custom volume size. I believe that there are/were some components of creating the rootfs URL arguments missing that piggybacking on the Disk section was causing. So since there are many other options you can pass for the rootFS anyway I'm working on adding it in as a new TF stanza; so instead of being nested under disk it'd be its own rootFS section
from terraform-provider-proxmox.
Yeah, I think having a separate node in the model for rootfs
params is a good idea.
from terraform-provider-proxmox.
Hey @DacoDev! Are you still working on this feature? If not, I can try finishing it...
from terraform-provider-proxmox.
Hey @bpg , Iβm sorry but no, I got lost in the sauce then school started (going back as an adult) and I ended up scrapping my ProxMox host in favor of a few smaller NUCs as a k8s cluster. I made a few commits after your patch but Iβm not sure if any of them would be useful, I think youβre a collaborator on my repo but let me know if you need me to push anything over!
from terraform-provider-proxmox.
No worries, I'll take a peek, thanks!
from terraform-provider-proxmox.
Hopefully this weekend π€
from terraform-provider-proxmox.
The DiskSize
field in RootFS
struct is read-only, so can't be used to change the FS size. However, there is a special syntax for the volume
field that allows to specify a different rootfs size at creation time. More details in https://pve.proxmox.com/pve-docs/chapter-pct.html#_storage_backed_mount_points.
So I basically started from scratch and implemented it like:
disk {
datastore_id = "local"
size = 10
}
Note that the datastore_id
field is mandatory if you want to customize the size.
Also, this feature can't be used (as of now) to resize the rootfs.
from terraform-provider-proxmox.
Related Issues (20)
- proxmox_virtual_environment_container managing mount_points HOT 7
- Cannot create volume mount point in LXC HOT 7
- Add support for `proxmox_virtual_environment_file` data source HOT 4
- Terraform VM Creation crashes plugin when adding ipv4 configuration to VM HOT 3
- Context Deadline Exceeded only on certain resources HOT 11
- Using Cloud Init package_upgrade: false HOT 1
- Error: resizing disk: error waiting for VM disk resize: All attempts fail: HOT 5
- After import command or block, unprivileged forces replacement HOT 2
- Live Migration error: retrieving VM 100: the requested resource does not exist HOT 3
- Recommended way to get Packer built VM ID into Terraform control HOT 9
- proxmox_virtual_environment_vm.virtual_machine already exists error HOT 2
- Please add new arguments and attributes to the `proxmox_virtual_environment_vms` data source HOT 2
- Unknown timezone "Europe/Amsterdam" with proxmox_virtual_environment_time HOT 2
- Changing disk size of 'proxmox_virtual_environment_container' forces replacement HOT 4
- proxmox_virtual_environment_download_file can't read metadata HOT 2
- CloudImage size changes forces replacement of VM HOT 2
- proxmox_virtual_environment_vm forces replacement by unchanged initialization.user_account.keys HOT 2
- A question about documentation related to the proxmox_virtual_environment_container resource
- Error listing files from datastore using API Token as credentials HOT 2
- Unable to download iso (OpenTofu) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-provider-proxmox.