Giter VIP home page Giter VIP logo

Comments (5)

robintibor avatar robintibor commented on June 3, 2024

Great that you put up that example. This is exactly what we need at the moment to verify real use cases. A quick scan through the code I didn't notice any reason unfortunately (you took care of shuffling, batch size etc.).
The accuracy_score at the very end of the script what does it output?

from braindecode.

sliwy avatar sliwy commented on June 3, 2024

One thing I didn't fix is random_seed (and I think we should freeze it) but for each run you can draw similar conclusions. I've run it again and the accuracy_score is 0.32 (validation: 0.29 from 1st epoch) in comparison to 0.45 from my function (validation 0.58 for epoch 21).

from braindecode.

sliwy avatar sliwy commented on June 3, 2024

Today I will submit an issue to skorch, to ask what is the difference between skorch training loop and the on defined by me. I saved numpy arrays to remove not needed data processing and include everything except model defininton in one file https://github.com/sliwy/braindecode/blob/strange_example/examples/skorch_ext_example.py
Let you know if I know anything new.

from braindecode.

sliwy avatar sliwy commented on June 3, 2024

I'm closing it as I've found the reason, in my train function there was a typo and I was setting model to train mode only at the beginning of training. After first validation step the model was in eval mode till the end of training.

from braindecode.

robintibor avatar robintibor commented on June 3, 2024

I see, great catch. Then it means that in your case it is actually better to train in eval mode?

from braindecode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.