BTVenmoClient `tokenize` async method leaks memory and does not return/throw an error when the user cancels the authorisation. about braintree_ios HOT 5 CLOSED

Hello @mdeaconu -

Glad to hear the new branch/PR is resolving the memory leak issue you saw previously. This change will go into our next release of the SDK and we will update this thread with the released version once completed.

from braintree_ios.

Hello @mdeaconu -

This was released in version 6.5.0. Please let us know if you run into any issues after making the update. Thanks again for bringing this issue to our attention! 🚀

from braintree_ios.

👋 Hi @mdeaconu - thank you for bringing this issues to us. I am trying to replicate it now.

Can you provide us with the URL that you're getting back in your scene or app delegate that you then pass to one of BTAppContextSwitcher's handleOpenURL methods?

from braintree_ios.

We are in the process of fixing the cancel case that you mentioned and will link that PR soon.

In the meantime, we were not able to replicate a memory leak like you showed. You should check on your VenmoTokenizationHandler.

Feel free to test on this branch we made which uses the async Swift function for BTVenmoClient.tokenize() in our Demo app (see specific line here). Using this Demo app, we aren't able to replicate a leak of BTVenmoClient.

from braintree_ios.

We are in the process of fixing the cancel case that you mentioned and will link that PR soon.

In the meantime, we were not able to replicate a memory leak like you showed. You should check on your VenmoTokenizationHandler.

Feel free to test on this branch we made which uses the async Swift function for BTVenmoClient.tokenize() in our Demo app (see specific line here). Using this Demo app, we aren't able to replicate a leak of BTVenmoClient.

Hello,
VenmoTokenizationHandler class acts similar to BraintreeDemoVenmoViewController which keeps a strong ref to BTVenmoClient. Normally it should go away and release memory once tokenize() call finishes.

Using the branch specified I was able to create some leaks:

2023-08-02 18:26:58.227297+0300 Demo[34922:145802] Fetching Client Token…
2023-08-02 18:27:00.933036+0300 Demo[34922:145802] Loading integration: BraintreeDemoVenmoViewController
2023-08-02 18:27:01.190886+0300 Demo[34922:145802] Using Client Token
2023-08-02 18:27:01.191329+0300 Demo[34922:145802] Presenting Demo.BraintreeDemoVenmoViewController
2023-08-02 18:27:03.457479+0300 Demo[34922:145802] Tapped Venmo - initiating Venmo auth
2023-08-02 18:27:13.406876+0300 Demo[34922:145802] Tapped Venmo ECD - initiating Venmo auth
SWIFT TASK CONTINUATION MISUSE: tokenize(_:) leaked its continuation!
2023-08-02 18:27:14.050144+0300 Demo[34922:145802] SWIFT TASK CONTINUATION MISUSE: tokenize(_:) leaked its continuation!
2023-08-02 18:40:22.739811+0300 Demo[34922:145802] Fetching Client Token…
2023-08-02 18:40:29.207586+0300 Demo[34922:145802] Loading integration: BraintreeDemoVenmoViewController
2023-08-02 18:40:29.466513+0300 Demo[34922:145802] Using Client Token
2023-08-02 18:40:29.466871+0300 Demo[34922:145802] Presenting Demo.BraintreeDemoVenmoViewController
2023-08-02 18:40:31.870273+0300 Demo[34922:145802] Tapped Venmo - initiating Venmo auth
2023-08-02 18:40:44.188042+0300 Demo[34922:145802] Tapped Venmo - initiating Venmo auth
SWIFT TASK CONTINUATION MISUSE: tokenize(_:) leaked its continuation!
2023-08-02 18:40:45.761560+0300 Demo[34922:145802] SWIFT TASK CONTINUATION MISUSE: tokenize(_:) leaked its continuation!
2023-08-02 18:40:52.471816+0300 Demo[34922:145802] Tapped Venmo - initiating Venmo auth
SWIFT TASK CONTINUATION MISUSE: tokenize(_:) leaked its continuation!
2023-08-02 18:40:53.112100+0300 Demo[34922:145802] SWIFT TASK CONTINUATION MISUSE: tokenize(_:) leaked its continuation!

Steps to reproduce:

1. Tap on Settings
2. Select Venmo - Custom Button Integration
3. Tap on Done
4. Tap several times on Venmo button (used MockVenmo sample app available)
5. Repeat step 1-4

However, I used this branch venmo-cancel-error and it looks the issue got fixed.

Will the change/fix be part of the next release? I am trying just to get an ETA.

Thanks!

from braintree_ios.